New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Trigger validation when next field is already filled out. #1072
Conversation
As asked in the comments on #952, a PR. |
Thanks! Will test this next week, along with other new PRs. Currently trying to reserve a few hours each Tuesday. |
Just tested this. #524 said:
Without your patch, the field doesn't get validated, even after deleting the value. With your patch applied, validation is immediately triggered when typing "a" into the field (same as #521). Did you run |
Yes, I run
With the patch, all tests succeed:
Travis also confirms my test results. The test I added for #521 is supposed to be functionally identical to the test case you provided on that issue, but apparently I made a mistake. You're right that running that fiddle test case with my latest version, validation is triggered immediately after typing a letter in the field. I don't immediately see my error, I'll take another look this evening. |
Okay, thanks! |
@stijnherreman did you ever get around to testing this again? |
@jzaefferer I haven't yet, some other things on the project I'm on had/have a higher priority unfortunately. I'll see if I can use some of my spare time soon for this. |
@stijnherreman would still be great to address this |
@jzaefferer I'm taking a look this weekend. |
Great, thank you. |
Would still be great to get the issue addressed. |
Closing due to inactivity. |
Fixes #524 (and #244) without causing #521.