Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #1730 #1731

Closed
wants to merge 3 commits into from
Closed

fix issue #1730 #1731

wants to merge 3 commits into from

Conversation

Alucelx
Copy link

@Alucelx Alucelx commented Mar 7, 2016

Fixes #1730

@Arkni
Copy link
Member

Arkni commented Mar 11, 2016

You should add a test to make sure that it fails without your patch and pass otherwise

@staabm staabm force-pushed the master branch 2 times, most recently from d621aab to 3861ce2 Compare September 26, 2016 14:28
@staabm
Copy link
Member

staabm commented Feb 11, 2017

Please add a test

@Alucelx
Copy link
Author

Alucelx commented Feb 22, 2017

@Arkni @staabm

this is the fixed test

https://jsfiddle.net/Alucelx/480b2osg/5/

@stale
Copy link

stale bot commented Jun 5, 2018

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up.
Thank you for contributing :)

@stale stale bot added the stale Used to mark stale issues label Jun 5, 2018
@stale stale bot closed this Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
NEEDS TEST stale Used to mark stale issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alucelx @Arkni @staabm