Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces in credit card numbers #47

Closed
wants to merge 1 commit into from

Conversation

KeeperPat
Copy link

Resolves #32.

This patch differs from the existing pull request in the following ways:

  • it adds test coverage for the modified behavior
  • it updates the comment on jquery.validate.js:1035 to be accurate (spaces are now allowed)
  • I didn't update the minified and packed versions or the zip file. I feel that is something that is probably automated at release time.

…4444", "5555-5555-5555-4444", and "5555 5555 5555 4444" are all valid credit card numbers. See http://unixwiz.net/ndos-shame.html for further discussion on why disallowing spaces in credit card number is a bad practice. Resolves jquery-validation#32
@CraigStuntz
Copy link

Duplicate of pull request 32, except that this one also updates the comment.

Neither PR has tests.

@jzaefferer
Copy link
Collaborator

Resolved via #218

@jzaefferer jzaefferer closed this Oct 6, 2011
mlynch pushed a commit to mlynch/jquery-validation that referenced this pull request Mar 28, 2012
…es are commonly input by users). Resolves (jquery-validation#47, jquery-validation#39, jquery-validation#32)

 * Changed code to allow spaces
 * Amended comment
 * Added Qunit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants