Skip to content
This repository has been archived by the owner on Nov 12, 2023. It is now read-only.

Multi-words display error #6

Closed
99MengXin opened this issue Mar 2, 2023 · 5 comments
Closed

Multi-words display error #6

99MengXin opened this issue Mar 2, 2023 · 5 comments
Labels
bug Something isn't working fixed Fixed in develop branch, waiting for release

Comments

@99MengXin
Copy link

Description

Multi-words display error.

To Reproduce

Steps to reproduce the behavior, e.g.:

  1. Create new text as below
The first was a new U.S. Department of Energy (DOE) report, which has not been made public.
  1. Click word DOE, input Department of Energy as parent then save it
  2. See error, multi-words will not display correctly

Solution

  1. Go Terms
  2. Search multi-words (here, Department of Energy)
  3. Click multi-words (here, Department of Energy)
  4. Click Update
  5. Go back to text, you can see multi-words display correctly

Extra software info, if not already included in the Description:

  • OS (e.g., iOS, windows): macOS
  • Browser (e.g., chrome, safari): brave
  • Web server (e.g., regular apache/php, MAMP, XAMP...): MAMP
  • Version (git commit): 1.1.3
@jzohrab
Copy link
Owner

jzohrab commented Mar 2, 2023

Reproduced on regular apache setup:

image

Then when I go into the "dept of energy" term and just click "save", it is highlighted correctly.

Thanks for the concise test case. Looking into it.

@jzohrab
Copy link
Owner

jzohrab commented Mar 2, 2023

Checked the saving to see if the term is somehow re-parsed differently. On re-save of the term, the db record is not changed. mysql> select *, replace(wotext, 0xe2808b, '/'), replace(wotextlc, 0xe2808b, '/') from words where woid = 3; is the same before and after.

@jzohrab
Copy link
Owner

jzohrab commented Mar 2, 2023

The parent term "dept of energy" isn't getting loaded into textitems2 when the DOE term is saved (select * from textitems2 where ti2txid = 7;), but it is loaded when the parent term is re-saved.

@jzohrab
Copy link
Owner

jzohrab commented Mar 2, 2023

Fixed in develop branch, tests passing locally. When dev passes GitHub CI, I'll make a new release and will verify and close this. Thanks @99MengXin for the issue.

@jzohrab jzohrab added bug Something isn't working fixed Fixed in develop branch, waiting for release labels Mar 8, 2023
@jzohrab
Copy link
Owner

jzohrab commented Mar 13, 2023

Fixed in v1.1.5.

image

Closing, thx.

@jzohrab jzohrab closed this as completed Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed Fixed in develop branch, waiting for release
Projects
None yet
Development

No branches or pull requests

2 participants