Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstring for format_version is wrong #128

Closed
zgoda-mobica opened this issue Apr 10, 2019 · 1 comment · Fixed by #129
Closed

Docstring for format_version is wrong #128

zgoda-mobica opened this issue Apr 10, 2019 · 1 comment · Fixed by #129

Comments

@zgoda-mobica
Copy link
Contributor

zgoda-mobica commented Apr 10, 2019 •
edited by scls19fr

https://github.com/k-bx/python-semver/blob/344ea8902a52b198534e15759925884601ac7509/semver.py#L403-L417

major, minor and patch can not be passed as str, despite docstring saying so because format specifier expects integers.
@scls19fr
Copy link
Member

Hi @zgoda-mobica

Good catch! Contributions are always welcome.

Best regards

@zgoda-mobica zgoda-mobica mentioned this issue Apr 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update doc for format_version to match expected param types zgoda-mobica/python-semver
2 participants
@scls19fr @zgoda-mobica