Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease comparisons not according to semver.org #21

Closed
tazle opened this issue Feb 10, 2016 · 2 comments
Closed

Prerelease comparisons not according to semver.org #21

tazle opened this issue Feb 10, 2016 · 2 comments

Comments

@tazle
Copy link
Contributor

tazle commented Feb 10, 2016

It seems that comparisons of pre-release versions do not work according semver.org specification:

Example:

$ python -c "import semver; print(semver.min_ver('1.2.3-rc2', '1.2.3-rc10'))"
1.2.3-rc2

According to semver.org, the parts after dash should be split at '.', and alphanumeric parts compared lexicographically and numeric parts numerically. It seems that this is not the case in semver-the-module.

@k-bx
Copy link
Contributor

k-bx commented Feb 10, 2016

Thanks for spotting! Would you care to make a PR on this one?

@k-bx
Copy link
Contributor

k-bx commented Feb 11, 2016

Released under 2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants