Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc for format_version to match expected param types #129

Merged
merged 1 commit into from Apr 15, 2019
Merged

Update doc for format_version to match expected param types #129

merged 1 commit into from Apr 15, 2019

Conversation

zgoda-mobica
Copy link
Contributor

This will fix #128

@scls19fr
Copy link
Member

Thanks @zgoda-mobica for your contribution.

@scls19fr scls19fr merged commit c399fe7 into python-semver:master Apr 15, 2019
@zgoda-mobica zgoda-mobica deleted the format_version_args branch April 16, 2019 05:59
@gene1wood
Copy link

This may have broken the build

scls19fr added a commit that referenced this pull request Apr 16, 2019
@scls19fr
Update semver.py
97232b2 
Revert #129
@scls19fr scls19fr mentioned this pull request Apr 16, 2019
Closed
@scls19fr
Copy link
Member

scls19fr commented Apr 16, 2019 •
edited

Good catch @gene1wood. I thought master branch was protected and merged too quickly!

I did a quick PR #130 to revert code ... but I don't think this problem is really related to this fix.

@scls19fr scls19fr mentioned this pull request Apr 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstring for format_version is wrong
3 participants
@zgoda-mobica @scls19fr @gene1wood