fix version comparisons #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if there is anything about this implementation you would like changed. |
k-bx
approved these changes
Jan 16, 2017
| @@ -232,7 +246,7 @@ def test_prerelease_order(): | |||
| assert min_ver('1.2.3-Rc10', '1.2.3-rc10') == '1.2.3-Rc10' | |||
| # Numeric identifiers always have lower precedence than non-numeric | |||
| # identifiers. | |||
| assert min_ver('1.2.3-2', '1.2.3-rc') == '1.2.3-rc' | |||
| assert min_ver('1.2.3-2', '1.2.3-rc') == '1.2.3-2' | |||
|
@pipermerriam released under 2.7.4, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
What was wrong?
The logic implementing the prerelease version comparisons was not quite correct.
How was it fixed?
Modified how pre-release tags are compared to ensure that all of the example test vectors from the semver spec evaluate correctly.
Cute animal picture