Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for KDE Plasma 6 #49

Closed
aenima99x opened this issue Jan 23, 2024 · 6 comments
Closed

Please add support for KDE Plasma 6 #49

aenima99x opened this issue Jan 23, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@aenima99x
Copy link

Is your feature request related to a problem? Please describe.
Does not run on Plasma6

Describe the solution you'd like
Would like widget to run on Plasma6

Describe alternatives you've considered
N/A

Additional context

@aenima99x aenima99x added the enhancement New feature or request label Jan 23, 2024
@k-donn
Copy link
Owner

k-donn commented Jan 23, 2024

Got it.

KDE has released a porting guide so I will begin to go through that (as well as update my own system).

@k-donn
Copy link
Owner

k-donn commented Mar 7, 2024

I made a first rough port. It is available for download on KDE Plasma 6 now through the KDE store.

link

Known issues:
The click to configure button does not work. Configuring through the context menu works however.
Icons and icon sizing are messed up.
Compact representation rendering is poor.

@aidanharris
Copy link

Thanks for taking a look at this.

I was using https://github.com/rliwoch/plasmoid-wunderground-extended but that's broken on Plasma 6 too now rliwoch#42

One issue, clicking on the Plasmoid in the panel doesn't seem to do anything right now (it doesn't show a forecast). It does show a forecast if I add it to the desktop.

@k-donn
Copy link
Owner

k-donn commented Mar 10, 2024

Got it. A new version is up on the store that fixed some of the panel problems. Plasma 6 has moved a lot of methods around so I am progressing bit by bit.

Next big problem is SVG rendering. Plasma 6 removed the file method of AppletInterface to find the path of resources in a plasmoid. And I cannot get relative paths to work.

Thank you!

@edwardp3
Copy link

edwardp3 commented Mar 11, 2024

I am testing OpenMandriva Cooker, with Plasma 6 and the current Plasma 6 widget isn't working. When adding, the icon is a green question mark and when selected to edit, a window displays the following:

Sorry! There was an error loading Wunderground.

file:///home/<username-redacted>/.local/share/plasma/plasmoids/com.github.k-donn.plasmoid-wunderground/contents/ui/main.qml:48:30: Invalid property assignment: int expected

EDIT: KDE info: Plasma 6.0.1, Frameworks 6.0.0, Qt: 6.7.0, on X11.

@k-donn
Copy link
Owner

k-donn commented Mar 13, 2024

The icon issue is some debug stuff I left in the metadata.json file so that's an easy fix.

The QML typing problem is a new error present in Qt 6.7.0. It does not allow null to be assigned to typed variables. Before the commit comes out, you can remove the null assignment and just have the currDayHigh(Low) be declared and not initialized to a value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants