/
openstackcloud_controller.go
346 lines (301 loc) · 13.3 KB
/
openstackcloud_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
/*
Copyright 2023.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package controller
import (
"context"
"errors"
"fmt"
"strings"
"time"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/client-go/tools/record"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/client/apiutil"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"github.com/gophercloud/gophercloud"
openstackv1 "github.com/k-orc/openstack-resource-controller/api/v1alpha1"
"github.com/k-orc/openstack-resource-controller/pkg/apply"
"github.com/k-orc/openstack-resource-controller/pkg/cloud"
"github.com/k-orc/openstack-resource-controller/pkg/conditions"
"github.com/k-orc/openstack-resource-controller/pkg/labels"
)
const (
OpenStackCloudFinalizer = "openstackcloud.k-orc.cloud"
)
// OpenStackCloudReconciler reconciles a OpenStackImage object
type OpenStackCloudReconciler struct {
client.Client
Scheme *runtime.Scheme
Recorder record.EventRecorder
}
func finalizerName(cloud *openstackv1.OpenStackCloud) string {
return OpenStackCloudFinalizer + "/" + cloud.Name
}
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstackclouds,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstackclouds/status,verbs=get;update;patch
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstackclouds/finalizers,verbs=update
//+kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch
//+kubebuilder:rbac:groups="",resources=secrets,verbs=patch
//+kubebuilder:rbac:groups="",resources=events,verbs=create;patch
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstackflavors,verbs=list
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstackfloatingips,verbs=list
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstackimages,verbs=list
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstackkeypairs,verbs=list
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstacknetworks,verbs=list
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstackports,verbs=list
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstackrouters,verbs=list
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstacksecuritygrouprules,verbs=list
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstacksecuritygroups,verbs=list
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstackservers,verbs=list
//+kubebuilder:rbac:groups=openstack.k-orc.cloud,resources=openstacksubnets,verbs=list
func (r *OpenStackCloudReconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Result, reterr error) {
logger := log.FromContext(ctx)
logger = logger.WithValues("OpenStackCloud", req.Name)
resource := &openstackv1.OpenStackCloud{}
err := r.Client.Get(ctx, req.NamespacedName, resource)
if err != nil {
if apierrors.IsNotFound(err) {
logger.Info("resource not found in the API")
return ctrl.Result{}, nil
}
return ctrl.Result{}, err
}
secretName := resource.Spec.Credentials.SecretRef.Name
if resource.DeletionTimestamp.IsZero() {
finalizerUpdated := controllerutil.AddFinalizer(resource, OpenStackCloudFinalizer)
newLabels := map[string]string{
openstackv1.OpenStackDependencyLabelSecret(secretName): "",
}
labelsMerger, labelsUpdated := labels.ReplacePrefixed(openstackv1.OpenStackLabelPrefix, resource.Labels, newLabels)
if finalizerUpdated || labelsUpdated {
logger.Info("applying labels and finalizer")
patch := &openstackv1.OpenStackCloud{}
patch.TypeMeta = resource.TypeMeta
patch.Finalizers = resource.GetFinalizers()
patch.Labels = labelsMerger
return ctrl.Result{}, apply.Apply(ctx, r.Client, resource, patch, "spec")
}
}
statusPatchResource := &openstackv1.OpenStackCloud{
Status: *resource.Status.DeepCopy(),
TypeMeta: resource.TypeMeta,
}
defer func() {
// If we're returning an error, report it as a TransientError in the Ready condition
if reterr != nil {
if updated, condition := conditions.SetNotReadyConditionTransientError(resource, statusPatchResource, reterr.Error()); updated {
// Emit an event if we're setting the condition for the first time
conditions.EmitEventForCondition(r.Recorder, resource, corev1.EventTypeWarning, condition)
}
}
if err := apply.ApplyStatus(ctx, r.Client, resource, statusPatchResource); err != nil && !(apierrors.IsNotFound(err) && len(resource.Finalizers) == 0) {
reterr = errors.Join(reterr, err)
}
}()
if len(resource.Status.Conditions) == 0 {
conditions.InitialiseRequiredConditions(resource, statusPatchResource)
}
if !resource.DeletionTimestamp.IsZero() {
return r.reconcileDelete(log.IntoContext(ctx, logger), resource, statusPatchResource)
}
if resource.Spec.Credentials.Source != openstackv1.OpenStackCloudCredentialsSourceTypeSecret {
updated, condition := conditions.SetErrorCondition(resource, statusPatchResource, openstackv1.OpenStackCloudCredentialsSourceInvalid,
"invalid credentials source "+resource.Spec.Credentials.Source)
// Emit an event if we're setting the condition for the first time
if updated {
conditions.EmitEventForCondition(r.Recorder, resource, corev1.EventTypeWarning, condition)
}
return ctrl.Result{}, nil
}
// Fetch the secret
secret := &corev1.Secret{}
{
secretRef := client.ObjectKey{Namespace: resource.Namespace, Name: secretName}
err := r.Client.Get(ctx, secretRef, secret)
if err != nil {
if !apierrors.IsNotFound(err) {
return ctrl.Result{}, err
}
}
// Secret either doesn't exist, or is being deleted
if err != nil || !secret.DeletionTimestamp.IsZero() {
logger.Info("waiting for secret")
if updated, condition := conditions.SetNotReadyConditionWaiting(resource, statusPatchResource, []conditions.Dependency{
{ObjectKey: secretRef, Resource: "secret"},
}); updated {
// Emit an event if we're setting the condition for the first time
conditions.EmitEventForCondition(r.Recorder, resource, corev1.EventTypeNormal, condition)
}
return ctrl.Result{}, nil
}
}
// Set our finalizer on the secret
if finalizer := finalizerName(resource); !controllerutil.ContainsFinalizer(secret, finalizer) {
logger.Info("adding finalizer to secret")
patchSecret, err := r.getEmptySecretPatch()
if err != nil {
return ctrl.Result{}, err
}
controllerutil.AddFinalizer(patchSecret, finalizer)
if err := apply.Apply(ctx, r.Client, secret, patchSecret); err != nil {
return ctrl.Result{}, err
}
}
// Test the credentials
{
_, _, err := cloud.NewProviderClient(ctx, r.Client, resource)
if err != nil {
logger.Error(err, "validating credentials")
switch err.(type) {
// Set BadCredentials for any non-transient error
case cloud.BadCredentialsError, gophercloud.ErrDefault400, gophercloud.ErrDefault401, gophercloud.ErrDefault403, gophercloud.ErrDefault404, gophercloud.ErrDefault405:
if updated, condition := conditions.SetErrorCondition(resource, statusPatchResource, conditions.OpenStackConditionReasonBadCredentials, err.Error()); updated {
// Emit an event if we're setting the condition for the first time
conditions.EmitEventForCondition(r.Recorder, resource, corev1.EventTypeWarning, condition)
}
return ctrl.Result{}, nil
default:
return ctrl.Result{}, fmt.Errorf("validating credentials: %w", err)
}
}
}
if updated, condition := conditions.SetReadyCondition(resource, statusPatchResource); updated {
conditions.EmitEventForCondition(r.Recorder, resource, corev1.EventTypeNormal, condition)
}
return ctrl.Result{}, nil
}
func (r *OpenStackCloudReconciler) getEmptySecretPatch() (*corev1.Secret, error) {
patchSecret := &corev1.Secret{}
gvk, err := apiutil.GVKForObject(patchSecret, r.Client.Scheme())
if err != nil {
return nil, fmt.Errorf("getting GVK for secret: %w", err)
}
patchSecret.APIVersion = gvk.GroupVersion().String()
patchSecret.Kind = gvk.Kind
return patchSecret, nil
}
func (r *OpenStackCloudReconciler) reconcileDelete(ctx context.Context, resource, statusPatchResource *openstackv1.OpenStackCloud) (ctrl.Result, error) {
logger := log.FromContext(ctx)
logger.Info("Reconciling delete")
logger.V(4).Info("Checking for OpenStack resources which reference this cloud")
referencingResources := []string{}
for _, resourceList := range []client.ObjectList{
&openstackv1.OpenStackFlavorList{},
&openstackv1.OpenStackFloatingIPList{},
&openstackv1.OpenStackImageList{},
&openstackv1.OpenStackKeypairList{},
&openstackv1.OpenStackNetworkList{},
&openstackv1.OpenStackPortList{},
&openstackv1.OpenStackRouterList{},
&openstackv1.OpenStackSecurityGroupList{},
&openstackv1.OpenStackSecurityGroupRuleList{},
&openstackv1.OpenStackServerList{},
&openstackv1.OpenStackSubnetList{},
} {
list := &unstructured.UnstructuredList{}
gvk, err := apiutil.GVKForObject(resourceList, r.Client.Scheme())
if err != nil {
return ctrl.Result{}, fmt.Errorf("getting GVK for resource list: %w", err)
}
list.SetGroupVersionKind(gvk)
if err := r.Client.List(ctx, list,
client.InNamespace(resource.GetNamespace()),
client.HasLabels{openstackv1.OpenStackDependencyLabelCloud(resource.GetName())},
client.Limit(1),
); err != nil {
logger.Error(err, "unable to list resources", "type", list.GetKind())
return ctrl.Result{}, err
}
if len(list.Items) > 0 {
referencingResources = append(referencingResources, list.Items[0].GetKind())
}
}
if len(referencingResources) > 0 {
logger.Info("OpenStack resources still referencing this cloud", "resources", referencingResources)
message := fmt.Sprintf("Resources of the following types still reference this cloud: %s", strings.Join(referencingResources, ", "))
if updated, condition := conditions.SetNotReadyConditionDeleting(resource, statusPatchResource, message); updated {
conditions.EmitEventForCondition(r.Recorder, resource, corev1.EventTypeWarning, condition)
}
// We don't have (and probably don't want) watches on every resource type, so we just have poll here
return ctrl.Result{RequeueAfter: time.Second * 10}, nil
}
logger.V(4).Info("Removing finalizer from secret")
if resource.Spec.Credentials.Source == openstackv1.OpenStackCloudCredentialsSourceTypeSecret {
// Remove all our fields from the secret
patchSecret, err := r.getEmptySecretPatch()
if err != nil {
return ctrl.Result{}, err
}
patchSecret.Name = resource.Spec.Credentials.SecretRef.Name
patchSecret.Namespace = resource.Namespace
if err := apply.Apply(ctx, r.Client, patchSecret, patchSecret); err != nil {
return ctrl.Result{}, fmt.Errorf("removing secret finalizer: %w", err)
}
}
if updated := controllerutil.RemoveFinalizer(resource, OpenStackCloudFinalizer); updated {
logger.Info("removing finalizer")
if updated, condition := conditions.SetNotReadyConditionDeleting(resource, statusPatchResource, "Removing finalizer"); updated {
conditions.EmitEventForCondition(r.Recorder, resource, corev1.EventTypeNormal, condition)
}
patch := &openstackv1.OpenStackCloud{}
patch.TypeMeta = resource.TypeMeta
patch.Finalizers = resource.GetFinalizers()
return ctrl.Result{}, apply.Apply(ctx, r.Client, resource, patch, "spec")
}
return ctrl.Result{}, nil
}
// SetupWithManager sets up the controller with the Manager.
func (r *OpenStackCloudReconciler) SetupWithManager(mgr ctrl.Manager) error {
return ctrl.NewControllerManagedBy(mgr).
For(&openstackv1.OpenStackCloud{}).
WithEventFilter(apply.IgnoreManagedFieldsOnly{}).
Watches(&corev1.Secret{}, handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, o client.Object) []reconcile.Request {
logger := mgr.GetLogger()
// Fetch a list of all OpenStackClouds that reference this secret.
kclient := mgr.GetClient()
clouds := &openstackv1.OpenStackCloudList{}
if err := kclient.List(ctx, clouds,
client.InNamespace(o.GetNamespace()),
client.HasLabels{openstackv1.OpenStackDependencyLabelSecret(o.GetName())},
); err != nil {
logger.Error(err, "unable to list OpenStackClouds")
return nil
}
// Reconcile each OpenStackCloud that references this secret.
reqs := make([]reconcile.Request, 0, len(clouds.Items))
for _, cloud := range clouds.Items {
if conditions.IsReady(&cloud) {
continue
}
reqs = append(reqs, reconcile.Request{
NamespacedName: client.ObjectKey{
Namespace: cloud.GetNamespace(),
Name: cloud.GetName(),
},
})
logger.V(5).Info("update of Secret triggers reconcile of OpenStackCloud",
"namespace", o.GetNamespace(),
"secret", o.GetName(),
"cloud", cloud.GetName())
}
return reqs
})).
Complete(r)
}