Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add fields for import and export policies #7

Closed
pspdbx opened this issue Apr 20, 2021 · 5 comments · Fixed by #13
Closed

Feature Request: Add fields for import and export policies #7

pspdbx opened this issue Apr 20, 2021 · 5 comments · Fixed by #13
Assignees
Labels
enhancement New feature or request

Comments

@pspdbx
Copy link

pspdbx commented Apr 20, 2021

Thank you very much for creating this plugin! Just what I was looking for to address a huge gap in the Netbox core model. We use import and export policies for every peer (for compliance), but are having trouble finding a good place to store that info in Netbox (custom fields are not a good fit). Can you please update your model to include fields to store the names of import and export policies? Both import and export policies can be a list of strings , for example ['BOGONS-REJECT', 'PRIVATE-PEER-IN'] , i.e. there could be more than one policy (order matters) for both import and export.

@k01ek
Copy link
Collaborator

k01ek commented Apr 21, 2021

Hi @pspdbx ! Glad to know that the plugin is helpful for you. I planed to add this functionality later.

@k01ek k01ek added the enhancement New feature or request label Apr 21, 2021
@k01ek k01ek self-assigned this Apr 21, 2021
@pspdbx
Copy link
Author

pspdbx commented Apr 21, 2021

Thank you @k01ek! My team is super excited to try this plugin out. We are going to try to deploy this in our Netbox in the coming days and explore the GUI and API.

With the import and export policies fields, it would really meet our requirements fully, and shape how some of our CLI tools, and other services consume the BGP peering data (which currently doesn't live in a structured form).

Thanks again for working on this feature; we are eagerly waiting for it! 😄

@pspdbx
Copy link
Author

pspdbx commented Apr 26, 2021

Hi @k01ek , could https://github.com/k01ek/netbox-bgp/blob/main/netbox_bgp/views.py#L91 cause performance problems when there are a large number of entries in the BGP session table?

@k01ek
Copy link
Collaborator

k01ek commented Apr 27, 2021

Hi @pspdbx ! I don' know. I need to test this issue. How many session do you have?

@k01ek k01ek linked a pull request Apr 28, 2021 that will close this issue
@k01ek k01ek closed this as completed Apr 28, 2021
@pspdbx
Copy link
Author

pspdbx commented Apr 28, 2021

Hi @pspdbx ! I don' know. I need to test this issue. How many session do you have?

Approximately 10,000. After reading more about https://github.com/netbox-community/netbox/blob/develop/netbox/netbox/views/generic.py#L74 , I think it's going to be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants