Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBox v3.2 support #81

Closed
jeremystretch opened this issue Feb 17, 2022 · 6 comments · Fixed by #88
Closed

NetBox v3.2 support #81

jeremystretch opened this issue Feb 17, 2022 · 6 comments · Fixed by #88
Labels
enhancement New feature or request

Comments

@jeremystretch
Copy link
Member

Hey there! I'd like to volunteer to implement support for NetBox v3.2. The first beta was recently released, and it greatly extends the plugins framework. We should be able to ensure support for NetBox v3.2 while removing a substantial amount of boilerplate/unsupported code. I did this recently for the netbox-dns plugin and it turned out very well.

If this would be helpful to you, I'll get to work shortly on a PR to adapt the current code base to the new framework. Of course it's entirely up to you whether to adopt the whole thing or implement specific changes piecemeal, but it should at least serve as a reference to hopefully minimize the work needed. Please let me know what you think!

@jeremystretch jeremystretch added the enhancement New feature or request label Feb 17, 2022
@k01ek
Copy link
Collaborator

k01ek commented Feb 18, 2022

Hi @jeremystretch! Thank you very much for your attention to the NetBox plugin system and to this plugin in particular. And of course many thanks for your work on NetBox, it's a great project. I keep a close eye on the latest changes to the NetBox plugins framework. Unfortunately, I could not participate in discussion due to lack of free time, but everything I needed was already voiced there.
I saw the pull request you made for the dns plugin. I have already made a new plugin based on the 3.2 version. It's really easy to create and maintain plugins now. This is what I've been waiting for a long time.
As for the changes for this plugin, it would be great if you could contribute, but to be honest, I think you already have a lot of work.

@ryanmerolle
Copy link

I think there is huge value in @jeremystretch helping in that he will get better views on if the approach he took to introduce features or fixes from the plugin discussion truly helped or added any additional burden/complexity.

If @jeremystretch & @k01ek do not collaborate on this plugin update, I think a collaboration on k01ek/netbox-plugin-skeleton might be a good idea to lower the barrier for new plugin creators, set an example for existing maintainers (who many already use this template), and standardize the overall workflow of development.

@jeremystretch
Copy link
Member Author

Like Ryan said, I benefit from this work too: Working through the migration process firsthand helps highlight tweaks that might still be needed to the plugins framework itself. We've already made a few resulting from the work I did on the DNS plugin. I think it'll really come into focus once I've gone through the same process with a few other plugins as well.

The plugin skeleton is also very cool! Interested to hear how you'd prefer to handle that for the new v3.2 framework.

@k01ek
Copy link
Collaborator

k01ek commented Feb 21, 2022

Okay, make the necessary changes. Let me know if you need any help or have questions.

@TheNetworkGuy
Copy link

Since Netbox 3.2 has been released, is it posible to update the plugin with a new tag for compatibility? :)

@k01ek
Copy link
Collaborator

k01ek commented Apr 6, 2022

@TheNetworkGuy sure! I am going to merge #85 and release new version this week.

@k01ek k01ek linked a pull request Apr 8, 2022 that will close this issue
@k01ek k01ek closed this as completed in #88 Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants