Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Deprecate ASN model in favor of NetBox 3.1.0 ASN model #82

Closed
ryanmerolle opened this issue Feb 19, 2022 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ryanmerolle
Copy link

Is your feature request related to a problem? Please describe.
NetBox 3.1.0 added the new ASN model allowing you to specify multiple sites to an ASN. It would be ideal to leverage said model, and extend it in the same way you have within this BGP plugin.

Describe the solution you'd like
Deprecate the custom plugin model for ASNs and leverage the core NetBox model. The only difference between the two is that the core model allows for:

  • multiple sites per ASN
  • tenant group assignments for ASNs
  • An RIR association

IE that means no current attribute of the netbox-plugin model would be missing.

Sessions would just be linked to the NetBox core model of ASN.

Describe alternatives you've considered
Keep the two separate and continue confusion within the API and UI.

Additional context
N/A

@dteknet
Copy link

dteknet commented Apr 26, 2022

There's also a conflict between the native ASNTable and the plugins' ASNTable interface configuration settings.
The thing is that a native one has the 'asn' field that is representing the number of AS, while the plugin has the 'number' field for that purpose. Each time I'm changing the table display setting for each table it rewrites the settings for another one.

image
image

@peterbaumert
Copy link

Hi @k01ek first of all cool work!
Im currently thinking on using your plugin too but i was wondering if i should wait till this change is implemented. Do you have any eta?

@k01ek
Copy link
Collaborator

k01ek commented Sep 13, 2022

Hi @peterbaumert ! Thanks for interest! I am gonna to make it this week.

@k01ek k01ek closed this as completed Sep 16, 2022
@peterbaumert
Copy link

Nice will try first thing monday :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants