Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different versions of C++ to CI #63

Closed
k06a opened this issue Dec 31, 2021 · 13 comments · Fixed by #77
Closed

Add different versions of C++ to CI #63

k06a opened this issue Dec 31, 2021 · 13 comments · Fixed by #77
Labels
CI Continuous integration enhancement

Comments

@k06a
Copy link
Owner

k06a commented Dec 31, 2021

Add C++11, C++14, C++17, C++20 to Travis-CI Matrix.

You can make boolinq-test to be compiled with all this standards. Remember that target boolinq-test14 is not compatible with C++11.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.03 ETH (110.54 USD @ $3684.59/ETH) attached to it.

@k06a k06a added the CI Continuous integration label Jan 1, 2022
@k06a
Copy link
Owner Author

k06a commented Jan 2, 2022

@mostafabarmshory code should be already compatible with these versions of C++ language 👌

@mostafabarmshory
Copy link

@k06a
I start to test the compatibility.
However, I`m not very familiar with the project. I need a little time to figure it out.

@tylerferrara
Copy link

tylerferrara commented Jan 2, 2022

Greetings @mostafabarmshory 👋
I'm working on #64 which also involves expanding the project's CI pipeline to include all the same C++ versions as this issue. Since @k06a suggests this project is already compatible with these versions, it should be simple. However, if you run into any complications, don't be afraid to reach out and communicate as our work will overlap.

@mostafabarmshory
Copy link

Tanks you
@tylerferrara
No special problem. I just read and had some tutorials in Travis CI. I was looking for a way to run Travis Build CI locally. I saw your discussion about AppVeyor.
Can you tell me more about it?

@mostafabarmshory
Copy link

Dear @k06a and @tylerferrara
I did with C++-11 and updated the Travis config. But I could not test it with travis itself right now. It dose not start the build process due to the following error:

We are unable to start your build at this time. You exceeded the number of users allowed for your plan. Please review your plan details and follow the steps to resolution.

I asked Travis support to check my account. I`ll push changes as soon as they enable my account and it pass all my tests.

@k06a
Copy link
Owner Author

k06a commented Jan 7, 2022

@mostafabarmshory try to open PR to this repo, I’ll try to start CI

@gitcoinbot
Copy link

gitcoinbot commented May 14, 2022

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 264 years, 3 months from now.
Please review their action plans below:

1) xav83 has been approved to start work.

Hi @k06a,

Before I can start to work on this issue, I have a few questions:

  • Do you have a Travis account linked to the repository boolinq ? (This would allow me to iterate on the Travis setup directly with your final CI process)
  • Does this issue concerns only the tests ? Or does it also concerns the bench ?
  • Do you already have some specific command or argument to compile the project with each of the C++ standard ? Or do I have to adapt the CMakeLists.txt files to be able to switch the C++ standard used ?

Thank you in advance for you answer,

Have a great day :-)

Learn more on the Gitcoin Issue Details page.

@Xav83
Copy link
Contributor

Xav83 commented Aug 18, 2022

Hi @k06a,

Before I can start to work on this issue, I have a few questions:

  • Do you have a Travis account linked to the repository boolinq ? (This would allow me to iterate on the Travis setup directly with your final CI process)
  • Does this issue concerns only the tests ? Or does it also concerns the bench ?
  • Do you already have some specific command or argument to compile the project with each of the C++ standard ? Or do I have to adapt the CMakeLists.txt files to be able to switch the C++ standard used ?

Thank you in advance for you answer,

Have a great day :-)

@k06a
Copy link
Owner Author

k06a commented Sep 4, 2022

@Xav83 hi!

  1. Yes I have Travis CI, but maybe better to use GitHub Actions, since it supports all the major operating systems and compilers?
  2. I think we can have both
  3. Please suggest what you think is better for the library, I do not have much experience with project configuration

@Xav83
Copy link
Contributor

Xav83 commented Sep 15, 2022

Hi @k06a,

If you want, I can use GitHub Actions instead of Travis CI.
Since it is directly integrated in GitHub and developed by GitHub, I would suggest you to indeed choose GitHub Actions.

I'll wait for you choice before starting the work on one or the other CI. 😉
If you choose GitHub Actions, could you update the description of the Gitcoin issue ?

@k06a
Copy link
Owner Author

k06a commented Oct 6, 2022

@Xav83 I think GitHub Actions is good enough, let's switch to it.

@Xav83
Copy link
Contributor

Xav83 commented Nov 16, 2022

Hi @k06a,

I have create a Pull Request draft which adds a GitHub Action workflow to compile boolinq-test with all the C++ versions.
I have 2 new questions:

  • Do you want GitHub Actions to test the compilation with several compilers ? Or the one by default is enough ?
    • -- The CXX compiler identification is GNU 9.4.0
  • For now, I only run boolinq-test on GitHub Actions. Do you want me to also run boolinq-test14 ? And boolinq-bench ?

If you want, we can also discuss about that directly on the Pull Request #76 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants