Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ogg and wav samples #20

Closed
hydrargyrum opened this issue Oct 18, 2020 · 1 comment · Fixed by #23
Closed

Support ogg and wav samples #20

hydrargyrum opened this issue Oct 18, 2020 · 1 comment · Fixed by #23

Comments

@hydrargyrum
Copy link
Contributor

Some games do not use FSB5 clips. I can work on a patch but I'm unsure about those:

  • RIFF/WAV has no metadata so no filename to return from extract_audioclip_samples
  • OGG would need another dependency to extract the file title metadata? (like mutagen, tagpy)
  • in an AudioClip, could there be multiple OGG (or WAV) samples/files?
@hydrargyrum
Copy link
Contributor Author

Should be fixed by #23

@hydrargyrum hydrargyrum mentioned this issue Oct 26, 2020
Merged
@K0lb3 K0lb3 closed this as completed in #23 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AudioClipConverter: support direct OGG and WAV content (no FSB5) hydrargyrum/UnityPy
1 participant
@hydrargyrum