Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in v2: $OPTS also passed to pgdumpall, so -Fc fails #12

Closed
hyperman2 opened this issue Feb 2, 2023 · 3 comments
Closed

Problem in v2: $OPTS also passed to pgdumpall, so -Fc fails #12

hyperman2 opened this issue Feb 2, 2023 · 3 comments

Comments

@hyperman2
Copy link

We run the debian/ubuntu version of this script with option -Fc to create .pgdump files instead of .sql files. In the v2 version, this fails: $OPTS is not only passed to pg_dump, but also to pg_dumpall. And theoptions for these 2 programs are not the same.

I'd suggest passing OPTS to only pg_dump, and add a new config variable OPS_PGDUMPALL or something.

Related bonus issue: the v1.1 version does not support pg_dump -Fd (which would allow parallel backups): changing rights on a directory failed.

@k0lter
Copy link
Owner

k0lter commented Feb 3, 2023

You're right, I will separate OPTS for pg_dump and pg_dumpall

I will also take a look for -Fd option

@k0lter
Copy link
Owner

k0lter commented Feb 6, 2023

I've pushed a fixed.

See Changelog for the new options.

@hyperman2
Copy link
Author

This works perfectly. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants