Markdown editor syntax highlighting issues

[heinrichreimer]

In syntax highlighting mode you can still edit the EditText but edits won't be saved when you switch back to normal edit mode. One simple solution would be to use

EditText.setEnabled(false)

which basically makes the EditText behave like a TextView.

The syntax highlighter also doesn't display horizontal lines and it displays ordered lists as unordered lists.

[k0shk0sh]

Yup, that will fix it, Thanks again for the heads up, I really appreciate it.

[heinrichreimer]

Just a suggestion but maybe adding a small indicator to the preview toggle could help to identify whether you are in edit mode currently. AnimatedVectorDrawable will be useful there.

[k0shk0sh]

Yup, I'm looking at implementing that in some places, like right now i'm doing them for star/fork/watch however thanks for pointing out that for the markdown editor.

[heinrichreimer]

It may also be an idea to use the same markdown render as for the readme and then just crossfade the editor EditText and the preview WebView

[k0shk0sh]

Yup, great idea, right now I'm working on changing the comments to WebViews. so for the mean time since sunday almost here, I guess I will go with this approach first then I'll see what I could do about it in term of enhancement as I really don't like the idea of having WebView in RecyclerView.

[heinrichreimer]

That's right.

[heinrichreimer]

You should hide the text controls like bold, italics, ... too when in preview mode

[k0shk0sh]

@heinrichreimer great idea 😄