Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is telemetry still sent even when disabled? #217

Closed
ukd1 opened this issue Sep 17, 2021 · 3 comments · Fixed by #226
Closed

Is telemetry still sent even when disabled? #217

ukd1 opened this issue Sep 17, 2021 · 3 comments · Fixed by #226

Comments

@ukd1
Copy link

ukd1 commented Sep 17, 2021

russ@Russells-MacBook-Pro scripts % k0sctl reset        
k0sctl v0.10.2 Copyright 2021, k0sctl authors.
Anonymized telemetry of usage will be sent to the authors.
....    

My k0sctl config:

apiVersion: k0sctl.k0sproject.io/v1beta1
kind: Cluster
metadata:
  name: k0s-cluster
spec:
  k0s:
    version: 1.22.2+k0s.0
    config:
      apiVersion: k0s.k0sproject.io/v1beta1
      kind: Cluster
      spec:
        telemetry:
          enabled: false
        storage:
          type: etcd
        network:
          provider: calico
          calico:
            mode: ipip
        extensions:
          helm:
            repositories:
            - name: metallb
              url: https://metallb.github.io/metallb
            - name: ingress-nginx
              url: https://kubernetes.github.io/ingress-nginx
            - name: prometheus-community
              url: https://prometheus-community.github.io/helm-charts
            charts:
            - name: ingress-nginx
              chartname: ingress-nginx/ingress-nginx
              namespace: default
            - name: metallb
              chartname: metallb/metallb
              namespace: default
              values: |
                configInline:
                  address-pools:
                   - name: default
                     protocol: layer2
                     addresses:
                      - 192.168.86.210-192.168.86.214
            - name: prometheus-stack
              chartname: prometheus-community/prometheus
              version: "11.16.8"
              values: |
                storageSpec:
                  emptyDir:
                    medium: Memory
              namespace: default
  hosts:
  - ssh:
      address: 192.168.86.210
      user: root
      port: 22
      keyPath: /Users/russ/.dotfiles/scripts/k8s/cluster.key
    role: controller+worker
  - ssh:
      address: 192.168.86.211
      user: root
      port: 22
      keyPath: /Users/russ/.dotfiles/scripts/k8s/cluster.key
    role: controller+worker
  - ssh:
      address: 192.168.86.212
      user: root
      port: 22
      keyPath: /Users/russ/.dotfiles/scripts/k8s/cluster.key
    role: controller+worker
  - ssh:
      address: 192.168.86.213
      user: root
      port: 22
      keyPath: /Users/russ/.dotfiles/scripts/k8s/cluster.key
    role: controller+worker
  - ssh:
      address: 192.168.86.214
      user: root
      port: 22
      keyPath: /Users/russ/.dotfiles/scripts/k8s/cluster.key
    role: controller+worker

note:

spec:
  k0s:
    config:
      spec:
        telemetry:
          enabled: false
@ukd1
Copy link
Author

ukd1 commented Sep 17, 2021

Ah; is this disabling it for k0s not k0sctl? 🤯

I've set:

DISABLE_TELEMETRY=true

in my env, and it appears to have stopped warning me when using the command. Can you confirm my config does disable the telemetry?

Also, sending telemetry is not mentioned at all in your docs - only in the LICENSE, and the CLI flag is hidden, which seems rather out of sight -- would you mind if I make PR to fix this?

@kke
Copy link
Contributor

kke commented Sep 20, 2021

Also, sending telemetry is not mentioned at all in your docs - only in the LICENSE, and the CLI flag is hidden, which seems rather out of sight -- would you mind if I make PR to fix this?

Sounds good to me!

@kke
Copy link
Contributor

kke commented Sep 20, 2021

You can see the telemetry events when running with --trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants