Only upload files if changed

[wenerme]

k0s and airgap bundle is about 500mb, should upload only changed

1. size+mtime to detect change
2. use sum to detect change

How do you think ?

BTW, I can contribute to this.

[kke]

k0s itself will only be reuploaded if you give a local path to it:

spec:
  hosts:
    - role: controller
      k0sBinaryPath: ~/k0s

The apply will also be treated as an upgrade, this is to ease k0s development / debugging with locally compiled binaries. If you let k0sctl manage the local cache, it should only upload the k0s binary if the version differs:

spec:
  hosts:
    - role: controller
      uploadBinary: true

For other uploads, to have a meaningful mtime, it should be set after upload to match the local file. I don't think checksumming is necessary.

[kke]

It would be nice if the remote stat would be implemented in https://github.com/k0sproject/rig which is used by k0sctl. It should probably return a fs.FileInfo derivative, something like:

type FileInfo fs.FileInfo
func (c Linux) Stat(h Host, path string) (FileInfo, error) {}
func (w Windows) Stat(h Host, path string) (FileInfo, error) {}

[wenerme]

Thought about add this to rig, but maybe this is too much, I finished my work by using ansible. Running k0s on zfs, there are extra steps before k0sctl apply.

phase in k0sctl ≈ ansible tasks, k0sctl may become something like apenella/go-ansible, but the executor is shell over ssh instead of ansible. From Configuration Complexity Clock, k0sctl is about 2am.

[twz123]

I still see file uploads of unchanged files in my test setup using 0.13.0-rc.1 ... 🤔