double sync

[lsanders]

I have just a single budket/prefix defined, but end up the the files from build in both the root AND the bucketPrefix and have the following log in serverless deploy

S3 Sync: Syncing directories and S3 prefixes...
........
S3 Sync: Synced.
S3 Sync: Syncing metadata...
.
S3 Sync: Synced metadata.

Here's the relevant config:

  s3Sync:
    - bucketName: ${self:custom.siteName}
      bucketPrefix: shell/
      localDir: build
      params:
        - 'index.html':
            CacheControl: 'max-age=0,no-cache,no-store,must-revalidate'
        - 'sw.js':
            CacheControl: 'max-age=0,no-cache,no-store,must-revalidate'

This deployed via bitbucket pipelines but I don't think that matters.

[nibynool]

@lsanders the log you provided is showing the two steps used to sync, so that is expected.

If you've changed the bucket prefix, then the files may still be in place from a previous deploy. Can you please verify that you've deleted the files from the root and then re-sync. If the problem persists either @k1LoW or I can try to replicate it and then work out the bug.

[ciege7041]

I have the same issue as the OP.

With the below configuration I get the contents of data-files in S3 in the falcon/importer/dev/ bucket as well as the root bucket `swagger-documents.

      bucketPrefix: falcon/importer/${self:custom.myStage} 
      localDir: data-files
      deleteRemoved: false # optional, indicates whether sync deletes files no longer present in localDir. Defaults to 'true'
      params:
        - "*.json":
            CacheControl: 'public, max-age=3600'
            ContentType: 'application/json'```


However with the following configuration:

- bucketName: swagger-documents
  bucketPrefix: falcon/importer/${self:custom.myStage} 
  localDir: data-files
  deleteRemoved: false # optional, indicates whether sync deletes files no longer present in localDir. Defaults to 'true'

I only get the file in the bucketPrefix folder. 

Is this intended?

[aaronhuisinga]

@k1LoW It does indeed appear this is a real issue. If params are defined in settings, the files are uploaded to both the root and bucketPrefix directory. If I remove the params config option, the files are correctly only uploaded to the bucketPrefix directory.

[k1LoW]

Thank you all !!

Now I'm lowering the development priority of this library.

If you are able to resolve this, we would encourage you to send a pull request.

[majindageta]

This looks closed by the merge of #94
(and i'm so happy my s3 bucket is so much clean)