Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Help wanted] Refactor cmake/onnxruntime.cmake #155

Closed
csukuangfj opened this issue May 12, 2023 · 2 comments · Fixed by #220
Closed

[Help wanted] Refactor cmake/onnxruntime.cmake #155

csukuangfj opened this issue May 12, 2023 · 2 comments · Fixed by #220
Labels
help wanted Extra attention is needed

Comments

@csukuangfj
Copy link
Collaborator

cmake/onnxruntime.cmake
is getting larger as we are adding support for more onnxruntime execution providers.

We need to split cmake/onnxruntime.cmake
into smaller files, where each file handles only one operating system.
@csukuangfj csukuangfj added the help wanted Extra attention is needed label May 12, 2023
@jingzhaoou
Copy link
Contributor

@csukuangfj I can give a try on this refactor since I want to add support for more execution providers myself. Hope to create a PR soon. If others want to contribute, please go ahead.

@csukuangfj
Copy link
Collaborator Author

@csukuangfj I can give a try on this refactor since I want to add support for more execution providers myself. Hope to create a PR soon. If others want to contribute, please go ahead.

Thanks!

@csukuangfj csukuangfj mentioned this issue Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor onnxruntime.cmake csukuangfj/sherpa-onnx
2 participants
@jingzhaoou @csukuangfj