Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

[CI/CD] - Add Lint support #26

Closed
burntcarrot opened this issue Nov 5, 2021 · 3 comments
Closed

[CI/CD] - Add Lint support #26

burntcarrot opened this issue Nov 5, 2021 · 3 comments
Assignees
Labels
Projects
Milestone

Comments

@burntcarrot
Copy link
Member

On running golangci-lint on my local machine, I was able to find 40+ linting issues.

10 of them were deadcode issues, so it can be ignored as they're a part of adding code for future releases.

The rest are ineffectual assignments and skipped error checks. We can log the error message for the skipped error checks; it would help us more in debugging.

I know this sounds like a minor issue, but with more code coming in the subsequent releases, addressing this earlier can help us save a lot of time maintaining good quality code.

Suggested Fix:
Add golangci-lint action as workflow to check linting issues. We can add a rule for excluding deadcode issues for now.

@burntcarrot
Copy link
Member Author

If you want me to fix this, can I open a PR?

@alefesta
Copy link
Member

alefesta commented Nov 5, 2021

yes please!!!!

@alefesta alefesta added the in progress Work in progress (max 4 weeks before automatic removal) label Nov 5, 2021
@alefesta alefesta added this to Current Iteration in roadmap Nov 5, 2021
@burntcarrot
Copy link
Member Author

Related PR: #27.

@alefesta alefesta added done and removed in progress Work in progress (max 4 weeks before automatic removal) todo 🗒️ labels Nov 5, 2021
@alefesta alefesta moved this from Current Iteration to Done in roadmap Nov 5, 2021
@alefesta alefesta closed this as completed Nov 5, 2021
@alefesta alefesta added this to the v1.0.1 milestone Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

No branches or pull requests

2 participants