You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
On running golangci-lint on my local machine, I was able to find 40+ linting issues.
10 of them were deadcode issues, so it can be ignored as they're a part of adding code for future releases.
The rest are ineffectual assignments and skipped error checks. We can log the error message for the skipped error checks; it would help us more in debugging.
I know this sounds like a minor issue, but with more code coming in the subsequent releases, addressing this earlier can help us save a lot of time maintaining good quality code.
Suggested Fix:
Add golangci-lint action as workflow to check linting issues. We can add a rule for excluding deadcode issues for now.
The text was updated successfully, but these errors were encountered:
On running
golangci-lint
on my local machine, I was able to find 40+ linting issues.10 of them were
deadcode
issues, so it can be ignored as they're a part of adding code for future releases.The rest are ineffectual assignments and skipped error checks. We can log the error message for the skipped error checks; it would help us more in debugging.
I know this sounds like a minor issue, but with more code coming in the subsequent releases, addressing this earlier can help us save a lot of time maintaining good quality code.
Suggested Fix:
Add
golangci-lint
action as workflow to check linting issues. We can add a rule for excludingdeadcode
issues for now.The text was updated successfully, but these errors were encountered: