Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings may crash with NumberFormatException if number="" (i.e. after choosing language). #10

Closed
Sammaz2 opened this issue May 17, 2018 · 1 comment
Labels
Milestone

Comments

@Sammaz2
Copy link

Sammaz2 commented May 17, 2018

Actual behavior

I opened the app and then i clicked on edit after that i clicked on select which is at the bottom of the right corner. And then in Settings I clicked on output zip file, short text file in zip, long file:Min text Len and then in long text file in zip, options. In all the options i removed all the text and putted numbers. After that I clicked on language and choosed a language. Suddenly the app crashed. And then i tried to open the app again. But everytime it always crashed.

How to reproduce

  • First you need to download the app from fdroid and then install it. After that open the app.

  • Click on the edit and then on select.

  • After that in settings press on the output zip file, short text file in zip, long file:Min text Len. And remove the text and numbers.

  • Then click on language and choose anyone. Suddenly the app will crash.

  • After that try to open the app. But unfortunately you will not be able to open the app. As it always crashes. U have to uninstall it and then install it again.

https://youtu.be/GGREadbCDFk

  • Browser: ToGozip

  • Version:2.0.12.180516

  • Operating system:7.1.2

  • Device model: Redmi 4

@k3b k3b added the bug label May 17, 2018
@k3b k3b added this to the 2.0.13 milestone May 17, 2018
@k3b
Copy link
Owner

k3b commented May 17, 2018

Thans for reporting

the issue is reproducable.

If

  • you remove the number value from a number field "long File: Min Text Len"
  • and then change the language
  • the settings activity is destroyed and then recreated with invalid number value
  • ==> crash with number format exception.

In my opinion this is a minor so i will not create a hotfix release.

Will be fixed with the next release 2.0.13.

k3b added a commit that referenced this issue May 17, 2018
@k3b k3b changed the title By choosing language app suddenly crashes. Settings may crash with NumberFormatException if number="" (i.e. after choosing language). May 17, 2018
@k3b k3b closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants