Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k3s token secret should be the responsibility of the control plane controller #69

Closed
cannonpalms opened this issue Nov 17, 2023 · 2 comments · Fixed by #71
Closed

k3s token secret should be the responsibility of the control plane controller #69

cannonpalms opened this issue Nov 17, 2023 · 2 comments · Fixed by #71

Comments

@cannonpalms
Copy link
Contributor

#68 solves the immediate issue of the secret being garbage collected during rollouts, but I don't think it is the right long-term solution.

The token is a concept that exists at the scope of the entire control plane / entire cluster, not the scope of a single machine or machine config.

Forcing the secret to be owned by the Cluster is a step forward, but longer term, I believe that it should be the responsibility of the control plane controller to manage this secret.

@cannonpalms
Copy link
Contributor Author

cc @mogliang

@mogliang
Copy link
Collaborator

Thanks, i agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants