-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't upgrade helm charts after deployment #32
Comments
Same problem here! |
Can you give an example of a before and after HelmChart CR that fails? |
I suspect issue is the job uses https://github.com/rancher/helm-controller/blob/master/pkg/helm/controller.go#L321 To make it more idempotent, we should probably change the args to |
I dug around some more.. here is a sample when install is present
Initial install works fine. When I update the manifest to a new version
https://github.com/rancher/klipper-helm/blob/master/entry#L33 I suspect check should be Because of equality comparison the code falls through and goes back to the default execution: https://github.com/rancher/klipper-helm/blob/master/entry#L33 After the tweak, the upgrade works as expected.
|
Perhaps using The weird thing is that I see this error after deleting the helm chart CR. Now I can't install that chart. |
+1 for this issue. My use case is with jupyterhub on k3s. Deploying initially works fine, redeploying with updates image or what have breaks with On regular |
I stopped using this and moved over to using HelmRelease from the fluxcd folks: |
Seems fixed in klipper-helm v0.2.4 and helm-controller v0.6.3 already ship klipper-helm v0.2.7. Can this issue be closed? Or problem is still there? |
Verified in k3s version v1.19.2+k3s1, above issue is resolved.
|
Closing this on behalf of @ShylajaDevadiga |
I'm using flux to deploy a HelmChart CRD into my k3s setup. The initial deploy works fine, but i update the HelmChart manifest with a new version of a chart the controller doesn't detect this as an upgrade. It attempts to do a new install of the chart, with the same deployment name. Which fails. Using v2 or v3 helm. With:
Error: cannot re-use a name that is still in use
Is this a feature that is planned to be added?
The text was updated successfully, but these errors were encountered: