Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable embedded helm controller #1445

Closed
ivan046 opened this issue Feb 23, 2020 · 3 comments
Closed

Ability to disable embedded helm controller #1445

ivan046 opened this issue Feb 23, 2020 · 3 comments
Assignees
Labels
kind/enhancement An improvement to existing functionality
Milestone

Comments

@ivan046
Copy link

ivan046 commented Feb 23, 2020

Is it possible to turn off K3S helm controller so it won't conflict with manually managed newer helm controller deployment from rancher's repo?

Adding --disable-helm-controller server installation argument will help a lot!
Thanks in advance.

@brandond
Copy link
Contributor

For the record, the helm controller in Rancher does not conflict with the one built in to K3s, as they do not watch the same CRD types. It is still useful to have an option to disable helm-controller though.

@brandond brandond modified the milestones: v1.21.3+k3s1, v1.22.0+k3s1 Jun 25, 2021
@brandond brandond added this to To Triage in Development [DEPRECATED] via automation Jun 25, 2021
@brandond brandond moved this from To Triage to Peer Review in Development [DEPRECATED] Jun 25, 2021
@brandond brandond added the kind/enhancement An improvement to existing functionality label Jun 25, 2021
@fapatel1 fapatel1 modified the milestones: v1.22.0+k3s1, v1.22.2+k3s1 Aug 23, 2021
@brandond brandond moved this from Peer Review to To Test in Development [DEPRECATED] Sep 28, 2021
@rancher-max
Copy link
Contributor

Validated this is working in v1.22.2+k3s1

  • Not using the flag allows k3s to continue working as expected
  • The flag is now present for k3s server and is working as expected when passed both as an exec arg or via the config.yaml file
  • Using the flag does not install helm resources by default (traefik and traefik crd), as expected
  • Using the flag does leave the crds for helmcharts.helm.cattle.io and helmchartconfigs.helm.cattle.io, as expected

Development [DEPRECATED] automation moved this from To Test to Done Issue / Merged PR Oct 4, 2021
@bo0tzz
Copy link

bo0tzz commented Jun 7, 2022

This flag is only documented in the HA installation guides, but seems to be missing from pages like the server config reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement An improvement to existing functionality
Projects
No open projects
Development

No branches or pull requests

6 participants