Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement --node-annotation #2626

Closed
iameli opened this issue Dec 4, 2020 · 2 comments
Closed

implement --node-annotation #2626

iameli opened this issue Dec 4, 2020 · 2 comments

Comments

@iameli
Copy link

iameli commented Dec 4, 2020

Is your feature request related to a problem? Please describe.
TLDR: k3s has --node-label=k=v already, it would be nice to have --node-annotation=k=v also.

My use case is actually still in the Rancher ecosystem; I'm setting up Longhorn and I'd like the nodes to be able to specify which disks they have. I need to add a label of

node.longhorn.io/create-default-disk: 'config'

And an annotation with a value of

node.longhorn.io/default-disks-config: '[{"path":"/mnt/HDD1","allowScheduling":true},{"path":"/mnt/HDD2","allowScheduling":true}]'

I can do the label with --node-label=node.longhorn.io/create-default-disk=config but there's no --node-annotation.

Describe the solution you'd like

--node-annotation=key=value

Describe alternatives you've considered

Presently I'm applying the annotations out-of-band in our provisioning process but it would be great to not need to do that.

@brandond
Copy link
Contributor

brandond commented Dec 4, 2020

This has been requested and denied upstream: kubernetes/kubernetes#60832

@iameli
Copy link
Author

iameli commented Dec 4, 2020

Fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants