Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K3s config.yaml flags not present in node-args annotation #3289

Closed
brandond opened this issue May 8, 2021 · 3 comments
Closed

K3s config.yaml flags not present in node-args annotation #3289

brandond opened this issue May 8, 2021 · 3 comments
Assignees
Labels
kind/enhancement An improvement to existing functionality
Milestone

Comments

@brandond
Copy link
Contributor

brandond commented May 8, 2021

Environmental Info:
K3s Version:
N/A

Node(s) CPU architecture, OS, and Version:
N/A

Cluster Configuration:
N/A

Describe the bug:
From @ibuildthecloud:

I really thought that k3s.io/node-args would have all the config values that came from the config.yaml file. It doesn't. Can it?

Steps To Reproduce:
Install K3s; use configuration from config.yaml instead of on CLI

Expected behavior:
Config from config file present in node-args annotation

Actual behavior:
Only actual CLI flags present in node-args annotation

Additional context / logs:

@brandond brandond added the kind/enhancement An improvement to existing functionality label May 8, 2021
@brandond brandond added this to the v1.21.1+k3s1 milestone May 8, 2021
@brandond brandond added this to To Triage in Development [DEPRECATED] via automation May 8, 2021
@brandond brandond moved this from To Triage to Working in Development [DEPRECATED] May 8, 2021
@brandond brandond moved this from Working to To Test in Development [DEPRECATED] May 14, 2021
@brandond brandond self-assigned this May 14, 2021
@ShylajaDevadiga
Copy link
Contributor

Validated in v1.21.1-rc1+k3s1

[centos@ip-172-31-1-111 ~]$ cat /etc/rancher/k3s/config.yaml 
write-kubeconfig-mode: "0644"
tls-san:
  - test
selinux: true
[centos@ip-172-31-1-111 ~]$ kubectl get node ip-172-31-1-111.us-east-2.compute.internal -o yaml|grep args
    k3s.io/node-args: '["server","--write-kubeconfig-mode","0644","--tls-san","test","--selinux","true","--node-external-ip","<redacted>","--datastore-endpoint","********"]'

Development [DEPRECATED] automation moved this from To Test to Done Issue / Merged PR May 17, 2021
@brandond
Copy link
Contributor Author

Reopening to see if @ibuildthecloud wants backports

@brandond brandond reopened this May 17, 2021
Development [DEPRECATED] automation moved this from Done Issue / Merged PR to Working May 17, 2021
@brandond brandond moved this from Working to To Test in Development [DEPRECATED] May 20, 2021
@brandond brandond moved this from To Test to Done Issue / Merged PR in Development [DEPRECATED] May 20, 2021
@brandond
Copy link
Contributor Author

OK with not backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement An improvement to existing functionality
Projects
No open projects
Development

No branches or pull requests

3 participants