Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/var/lib/rancher/k3s/server/manifests files must conform to RFC1123 #7012

Closed
strowi opened this issue Mar 2, 2023 · 1 comment
Closed

/var/lib/rancher/k3s/server/manifests files must conform to RFC1123 #7012

strowi opened this issue Mar 2, 2023 · 1 comment

Comments

@strowi
Copy link

strowi commented Mar 2, 2023

Environmental Info:
K3s Version:
v1.24.10+k3s1

Describe the bug:
I put some manifests into /var/lib/rancher/server/manifests containing underscores hcloud_secret.yaml, and it didn't get deployed.
Since this is about the filename, which is totally valid (and common pattern) on most filesystems i wouldn't expect this to be a problem.
Looking into the k3s logs i found:

[12874]: time="2023-03-02T10:49:26Z" level=error msg="Failed to process config: failed to process /var/lib/rancher/k3s/server/manifests/hcloud_secret.yaml: Addon.k3s.cattle.io \"hcloud_secret\" is invalid: metadata.name: Invalid value: \"hcloud_secret\": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

If this is wanted/expected behaviour for k3s i would at least want a documentation update since this isn't mentioned on https://docs.k3s.io/advanced#auto-deploying-manifests and took me some time to figure out.

Steps To Reproduce:
Put a valid file containing an underscore into the above folder.

Expected behavior:

I would expect it to deploy.

Actual behavior:

It doesn't get deployed.

Additional context / logs:

@strowi strowi changed the title /var/lib/rancher/k3s/server/manifests must conform to RFC1123 /var/lib/rancher/k3s/server/manifests files must conform to RFC1123 Mar 2, 2023
@caroline-suse-rancher
Copy link
Contributor

Fixed in the above PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants