[Release-1.28] - K3s should not disable etcd and apiserver when used with kine

[vitorsavian]

Backport fix for K3s should not disable etcd and apiserver when used with kine

• K3s should not disable etcd and apiserver when used with kine #9765

[VestigeJ]

##Environment Details
Reproduced using VERSION=v1.28.8+k3s1
Validated using COMMIT=70bd37793f0eadb9de3f8e5a224d2a9eb75c38b7

Infrastructure

• Cloud

Node(s) CPU architecture, OS, and version:

Linux 5.14.21-150500.53-default x86_64 GNU/Linux
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP5"

Config.yaml:

node-external-ip: 8.6.5.5
token: YOUR_TOKEN_HERE
write-kubeconfig-mode: 644
debug: true
profile: cis
selinux: true
protect-kernel-defaults: true

Reproduction

$ curl https://get.k3s.io --output install-"k3s".sh
$ sudo chmod +x install-"k3s".sh
$ sudo groupadd --system etcd && sudo useradd -s /sbin/nologin --system -g etcd etcd
$ sudo modprobe ip_vs_rr
$ sudo modprobe ip_vs_wrr
$ sudo modprobe ip_vs_sh
$ sudo printf "on_oovm.panic_on_oom=0 \nvm.overcommit_memory=1 \nkernel.panic=10 \nkernel.panic_ps=1 \nkernel.panic_on_oops=1 \n" > ~/90-kubelet.conf
$ sudo cp 90-kubelet.conf /etc/sysctl.d/
$ sudo systemctl restart systemd-sysctl
$ COMMIT=70bd37793f0eadb9de3f8e5a224d2a9eb75c38b7
$ sudo INSTALL_K3S_COMMIT=$COMMIT INSTALL_K3S_SKIP_ENABLE=true ./install-k3s.sh
$ sudo /usr/local/bin/k3s server --datastore-endpoint "test" --disable-etcd -s "https://192.168.1.0:6443"

Results:

//before update

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x21415e2]

goroutine 1 [running]:
github.com/k3s-io/k3s/pkg/clientaccess.(*Info).Get(0x0, {0x5f77d5c, 0x8}, {0x0, 0x0, 0x0})
	/go/src/github.com/k3s-io/k3s/pkg/clientaccess/token.go:279 +0x42
github.com/k3s-io/k3s/pkg/etcd.ClientURLs({0xc0007bfda0?, 0x0?}, 0xc000a5b0e0?, {0x0, 0x0})
	/go/src/github.com/k3s-io/k3s/pkg/etcd/etcd.go:1367 +0x6d
github.com/k3s-io/k3s/pkg/cluster.(*Cluster).Start(0xc0007bfda0, {0x6e6d370?, 0xc000a5b0e0})
	/go/src/github.com/k3s-io/k3s/pkg/cluster/cluster.go:47 +0x105
github.com/k3s-io/k3s/pkg/daemons/control.prepare({0x6e6d370, 0xc000a5b0e0}, 0xc000761408)
	/go/src/github.com/k3s-io/k3s/pkg/daemons/control/server.go:262 +0x2ff
github.com/k3s-io/k3s/pkg/daemons/control.Server({0x6e6d370?, 0xc000a5b0e0}, 0xc000761408)
	/go/src/github.com/k3s-io/k3s/pkg/daemons/control/server.go:35 +0xf7
github.com/k3s-io/k3s/pkg/server.StartServer({0x6e6d370?, 0xc000a5b0e0}, 0xc000761400, 0x1?)
	/go/src/github.com/k3s-io/k3s/pkg/server/server.go:56 +0x85
github.com/k3s-io/k3s/pkg/cli/server.run(0xc000a922c0, 0xa730500, {0xc00131e9b0, 0x0, 0x0?}, {0xc00131e9b0, 0x0, 0xa2cb4e0?})
	/go/src/github.com/k3s-io/k3s/pkg/cli/server/server.go:490 +0x33ba
github.com/k3s-io/k3s/pkg/cli/server.Run(0xc000a922c0?)
	/go/src/github.com/k3s-io/k3s/pkg/cli/server/server.go:44 +0x2f
github.com/urfave/cli.HandleAction({0x53519a0?, 0x6612298?}, 0x6?)
	/go/pkg/mod/github.com/urfave/cli@v1.22.14/app.go:524 +0x50
github.com/urfave/cli.Command.Run({{0x5f554ab, 0x6}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0x60fe092, 0x15}, {0xc0012ba750, ...}, ...}, ...)
	/go/pkg/mod/github.com/urfave/cli@v1.22.14/command.go:175 +0x63e
github.com/urfave/cli.(*App).Run(0xc000417880, {0xc0000497a0, 0xd, 0xe})
	/go/pkg/mod/github.com/urfave/cli@v1.22.14/app.go:277 +0xb27
main.main()
	/go/src/github.com/k3s-io/k3s/cmd/server/main.go:81 +0xbfb

//after code fix implementation

$ sudo /usr/local/bin/k3s server --datastore-endpoint "test" --disable-etcd -s "https://192.168.1.0:6443"

FATA[0000] invalid flag use; cannot use --disable-etcd with --datastore-endpoint