Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSI snapshot CRDs/controller/webhook #6459

Closed
wants to merge 5 commits into from

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Nov 7, 2022

Proposed Changes

Add a bundled HelmChart for the CSI snapshot CRDs, controller, and validation webhook. Ref: https://kubernetes.io/docs/concepts/storage/volume-snapshots/

The CRDs and snapshot controller installations are the responsibility of the Kubernetes distribution.

Uses the charts from piraeusdatastore because upstream does not want to maintain their own charts, as per kubernetes-csi/external-snapshotter#622 (comment)

Types of Changes

new feature

Verification

Start k3s without --disable=snapshot-controller; note deployment of two new pods.

Testing

  • tbd

Linked Issues

User-Facing Change

K3s now bundles the Kubernetes SIG-Storage CSI Snapshot Controller and Validating Webhook, as a HelmChart. This may be disabled by starting k3s with `--disable=snapshot-controller`.

Further Comments

@brandond brandond changed the title Add CSI snapshot controller Add CSI snapshot CRDs/controller/webhook Nov 16, 2022
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
Copy link
Contributor Author

brandond commented Dec 1, 2022

We've decided not to do this, in favor of covering use of the piraeusdatastore chart in the docs. I'll open a new ADR to cover this decision.

@omidraha
Copy link

I reached this issue through longhorn/longhorn#2551 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants