Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add TopPlacement field to SharedApi #179

Closed
ivenuss opened this issue May 13, 2024 · 1 comment
Closed

[ENHANCEMENT] Add TopPlacement field to SharedApi #179

ivenuss opened this issue May 13, 2024 · 1 comment
Assignees
Labels
Enhancement Updates that enhance or improve existing features without adding new ones. Priority: Low Minor issues that have little impact on the project's immediate progress.

Comments

@ivenuss
Copy link

ivenuss commented May 13, 2024

Describe the enhancement

Add new field TopPlacement to SharedApi. It should return given player placement.

Concept structure

K4-SharedApi.cs

int TopPlacement { get; }

PluginAPI.cs

public int TopPlacement
{
	get
	{
		if (_player is null || !_player.IsValid || !_player.IsPlayer || _player.rankData is null)
			throw new Exception("K4-SharedAPI > TopPlacement (get) > Player is not valid or is not a player.");

		return _player.rankData.TopPlacement;
	}
}
@ivenuss ivenuss added Enhancement Updates that enhance or improve existing features without adding new ones. Priority: Low Minor issues that have little impact on the project's immediate progress. labels May 13, 2024
@K4ryuu
Copy link
Owner

K4ryuu commented May 16, 2024

The feature has been added to the upcoming release. It is going to be uploaded when I have finished with the rest

@K4ryuu K4ryuu closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Updates that enhance or improve existing features without adding new ones. Priority: Low Minor issues that have little impact on the project's immediate progress.
Projects
None yet
Development

No branches or pull requests

2 participants