Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option for Scaling #17

Closed
wuast94 opened this issue Oct 22, 2018 · 4 comments
Closed

Add Option for Scaling #17

wuast94 opened this issue Oct 22, 2018 · 4 comments
Assignees
Labels
type:Enhancement New feature or request

Comments

@wuast94
Copy link

wuast94 commented Oct 22, 2018

would be nice to say i want the file x times larger and not to tell the exact resolution.

and thank you for all your work at this :)

@k4yt3x
Copy link
Owner

k4yt3x commented Oct 22, 2018

We used to have this option, -f, --factor for scaling. However, since waifu2x takes in the format of "widthxheignt", I removed it since some videos were out of ratio for some reasons after upscaling. I will look into getting this feature back, because I know it would be a nice thing to have.

And you're welcome. This project was developed during the hackathon "hackthevalley 2", where we didn't even get an award. I never thought it would actually get popular. I've been losing sleep a bit these few days. After I get all the other things settled, I will reconstruct the structure of the code so it's more elegant and robust.

@k4yt3x k4yt3x self-assigned this Oct 22, 2018
@k4yt3x k4yt3x added the type:Enhancement New feature or request label Oct 22, 2018
@wuast94
Copy link
Author

wuast94 commented Oct 22, 2018

would love to help coding but i´m not a coder :D can read a lot of things but never coded my self :/ but it´s a thing i should learn :D

@k4yt3x
Copy link
Owner

k4yt3x commented Oct 22, 2018

It's nice to be able to code, so you can make anything that you want or need.

@k4yt3x k4yt3x changed the title add option for scaling Add Option for Scaling Oct 23, 2018
@k4yt3x k4yt3x added this to To do in Version 2.2.0: Enhancement Update via automation Nov 9, 2018
@k4yt3x k4yt3x moved this from To do to In progress in Version 2.2.0: Enhancement Update Nov 26, 2018
@k4yt3x
Copy link
Owner

k4yt3x commented Nov 30, 2018

I've already added the --factor option.

@k4yt3x k4yt3x closed this as completed Nov 30, 2018
Version 2.2.0: Enhancement Update automation moved this from In progress to Done Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants