Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace all CSS classes #29

Open
toolness opened this issue Oct 19, 2012 · 1 comment
Open

Namespace all CSS classes #29

toolness opened this issue Oct 19, 2012 · 1 comment

Comments

@toolness
Copy link
Collaborator

This might be going overboard, but since webmaker-nav is meant to be embedded on arbitrary pages, I wonder if it'd be useful to namespace all its classes under e.g. wmnav-, so they don't conflict with pages' existing styles. Just an idea.

@k88hudson
Copy link
Owner

Yep, we should definitely do this.

Also, we could use a good reset, and probably avoid using h1, h2, h3, h4, h5 and maybe even p to prevent accidental inheritance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants