Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart: imagePullSecrets is array of key/value pairs in ServiceAccount but an array of strings in schema definition #1027

Open
ErikLundJensen opened this issue Nov 16, 2022 · 1 comment

Comments

@ErikLundJensen
Copy link
Contributor

When I try to add imagePullSecrets I get this error:
global.imagePullSecrets.0: Invalid type. Expected: string, given: object

From documentation in values.yaml where imagePullSecrets is an Array of key/value pairs.

global:
  # -- Reference to one or more secrets to be used when pulling images 
  # ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
  imagePullSecrets: []
  # - name: "image-pull-secret

Definition from the schema json:

"Global": {
            "type": "object",
            "additionalProperties": false,
            "properties": {
                "imagePullSecrets": {
                    "type": "array",
                    "items": {
                        "type": "string",
                        "minLength": 1
                    }
                }
            },
            "title": "Global"
        },

I expected that the schema to specify an array of key/values.

@jkremser
Copy link
Member

right, name: "image-pull-secret" != "image-pull-secret"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants