Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump coredns helm chart dependency to get support for imagePullSecrets #1028

Open
ErikLundJensen opened this issue Nov 16, 2022 · 5 comments

Comments

@ErikLundJensen
Copy link
Contributor

Update dependency to CoreDNS from 1.15.3 to at least 1.16.7 to get support for imagePullSecrets in CoreDNS

See also https://github.com/coredns/helm/blob/master/charts/coredns/values.yaml#L13

@k0da
Copy link
Collaborator

k0da commented Nov 16, 2022

We use forked chart

@ErikLundJensen
Copy link
Contributor Author

Should I create an issue in https://github.com/AbsaOSS/coredns-helm for getting the fork updated with new version of CoreDNS?

@k0da
Copy link
Collaborator

k0da commented Nov 16, 2022

yes, please

@ErikLundJensen
Copy link
Contributor Author

I can't create an issue as AbsaOSS/coredns-helm is a fork. Let's get the original CoreDNS to implement the skipConfigMap.
I do see a PR for CoreDNS which is stuck:
coredns/helm#41

k0da could you update the PR so there are no conflicts. Then I'll then push for the review and merge of it.

@somaritane
Copy link
Contributor

@ErikLundJensen I've enabled the issue creation in the AbsaOSS/coredns-helm
Not sure if all changes made there have been pushed to the upstream.
@k0da we might want to move this fork to k8gb.io org umbrella.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants