Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s version matrix #1044

Open
kuritka opened this issue Dec 8, 2022 · 6 comments
Open

k8s version matrix #1044

kuritka opened this issue Dec 8, 2022 · 6 comments
Labels
CI all the things related to gh actions or workflow enhancement New feature or request good first issue Good for newcomers

Comments

@kuritka
Copy link
Collaborator

kuritka commented Dec 8, 2022

We need to verify that k8gb will run on different versions of kubernetes. We could take one simple terratest and run it on several k3d-actions but with different k3s versions.

We are already doing something similar when we test our libraries across different GO versions: here

@kuritka kuritka added enhancement New feature or request good first issue Good for newcomers CI all the things related to gh actions or workflow labels Dec 8, 2022
@ytsarev
Copy link
Member

ytsarev commented Feb 4, 2023

@kuritka while supporting k8s version matrix totally makes sense, do we really need to keep compatibility with older golang versions? what is the motivation to do so? we are just shipping controller binary, not a library so maybe we can simplify the golang test matrix?

@kuritka
Copy link
Collaborator Author

kuritka commented Feb 6, 2023

Hi @ytsarev , sorry, it's a misunderstanding. I mean the matrix for k8s version only. GO versions were given as an example of how it should work.

thx

@Horiodino
Copy link

Hii @kuritka @ytsarev i would like to contribute to this project but can you guys give more context about this issue.

@ytsarev
Copy link
Member

ytsarev commented Jul 29, 2023

Hi @Horiodino , welcome to the project! We really appreciate your willingness to contribute!

The context is pretty simple. It is about to provide a well-tested version of https://github.com/k8gb-io/k8gb#production-readiness table supported by automated tests.

@Horiodino
Copy link

Hi @Horiodino , welcome to the project! We really appreciate your willingness to contribute!

The context is pretty simple. It is about to provide a well-tested version of https://github.com/k8gb-io/k8gb#production-readiness table supported by automated tests.

than-you @ytsarev for replying , so basically it for testing the k8sgb on different kubernetes version and go lang for providing more compatibility ?

@kuritka
Copy link
Collaborator Author

kuritka commented Jul 31, 2023

Hi @Horiodino , appreciate your interresets. Doing Golang version matrix is not important in case of k8gb project and would complicate the pipeline unnecessarily. I just used it as an example of how to implement a matrix and I didn't have anything better at hand at the time. Different versions of kubernetes are important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI all the things related to gh actions or workflow enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants