Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unnecessary permissions #1580

Closed
Yseona opened this issue May 30, 2024 · 3 comments
Closed

Bug: Unnecessary permissions #1580

Yseona opened this issue May 30, 2024 · 3 comments

Comments

@Yseona
Copy link

Yseona commented May 30, 2024

Hi community!

I just found that the Deployment k8gb in the charts has delete verb for the ingresses resource (role.yaml). However, after reading the source code of k8gb, I didn't find any Kubernetes API usages that require delete ingresses permissions. Therefore, for security reasons, I suggest checking this permission to determine if it is truly unnecessary. If it is, the issue should be fixed by removing the unnecessary permission or other feasible methods.

@ytsarev
Copy link
Member

ytsarev commented Jun 3, 2024

Hi, thanks for the report! I think that's a good catch, as we are only creating and updating ingresses as of now. PR is highly welcomed :)

@abaguas
Copy link
Contributor

abaguas commented Jun 30, 2024

I believe the delete permission is required. A GSLB resource creates an ingress resource from the embedded spec. When that GSLB is deleted it deletes the ingress it created. The deletion is done through a finalizer since the GSLB resource owns the Ingress, that is why the source code doesn't include an explicit deletion.

@ytsarev
Copy link
Member

ytsarev commented Jul 1, 2024

@abaguas that's actually good point for the case of full embedded Ingress ownership, we need deletion. Closing

@ytsarev ytsarev closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants