Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework cache & add gcs cache option #262

Merged
merged 5 commits into from
Nov 18, 2023

Conversation

matthisholleville
Copy link
Contributor

Closes #

πŸ“‘ Description

Rework cache & add GCS cache option to match with this PR k8sgpt-ai/k8sgpt#750

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

PR dependencies :

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
AlexsJones
AlexsJones previously approved these changes Nov 15, 2023
arbreezy
arbreezy previously approved these changes Nov 15, 2023
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , lets merge after the schema PR is merged too

AlexsJones and others added 2 commits November 16, 2023 13:39
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@AlexsJones AlexsJones merged commit c9f1290 into k8sgpt-ai:main Nov 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants