fix: change deployment image reconciling #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ultram4rine <ultramarine730@gmail.com>
ultram4rine
force-pushed
the
fix/wrong-deployment-image-processing
branch
from
4114316
to
b4f4b0d
Compare
Signed-off-by: ultram4rine <ultramarine730@gmail.com>
arbreezy
reviewed
Apr 19, 2024
arbreezy
requested changes
Apr 19, 2024
ultram4rine
force-pushed
the
fix/wrong-deployment-image-processing
branch
from
71db2f7
to
19dee35
Compare
|
New func should work, playground: https://go.dev/play/p/eYTOsZhlJGH |
arbreezy
approved these changes
Apr 21, 2024
4 tasks
MateSousa
pushed a commit
to MateSousa/k8sgpt-operator
that referenced
this pull request
May 2, 2024
* fix: change deployment image reconciling Signed-off-by: ultram4rine <ultramarine730@gmail.com> * improve image reconciling Signed-off-by: ultram4rine <ultramarine730@gmail.com> --------- Signed-off-by: ultram4rine <ultramarine730@gmail.com> Co-authored-by: Aris Boutselis <arisboutselis08@gmail.com> Signed-off-by: Matheus Sousa <matessousa@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #346
📑 Description
Fix deployment image update if repository has a port.
✅ Checks
ℹ Additional Information
Also change
Update the deployment imagebehavior. Now it will keep deployment image in sync with repo and version fromK8sGPTCRD. Please tell me if this is wrong.