Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add more filter relevant UT in analysis_test.go #435

Merged
merged 3 commits into from May 22, 2023
Merged

chore: add more filter relevant UT in analysis_test.go #435

merged 3 commits into from May 22, 2023

Conversation

panpan0000
Copy link
Contributor

Closes #NA

It's the UT code from closed PR #402
I thinks the UT is worthy, so contribute them again.

📑 Description

3 new cases to test:

  • The user adds --filter in his analysis command
  • We get the actives_filters (stored in the configuration file)
  • Neither of them is specified and we use the core analyzers

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@panpan0000 panpan0000 requested review from a team as code owners May 18, 2023 00:17
AlexsJones
AlexsJones reviewed May 19, 2023
View reviewed changes
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you - just a comment around signature casing

pkg/analysis/analysis_test.go Outdated Show resolved Hide resolved
AlexsJones
AlexsJones reviewed May 19, 2023
View reviewed changes
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you - just a comment around signature casing

@panpan0000
chore: add more filter releavent UT in analysis_test.go
1de3a56 
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
@panpan0000
Copy link
Contributor Author

done, thank Alex

@AlexsJones AlexsJones enabled auto-merge (squash) May 22, 2023 05:40
@AlexsJones AlexsJones merged commit 36995fd into k8sgpt-ai:main May 22, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@panpan0000 @AlexsJones