Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append coreAnalyzer if active_filter is empty and integration is added #441

Merged

Conversation

matthisholleville
Copy link
Contributor

Closes #412

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

(matthisholleville) ➜  k8sgpt git:(fix/integration-and-filters) go run main.go filters list                
Active: 
> PersistentVolumeClaim
> Ingress
> Node
> Deployment
> ReplicaSet
> StatefulSet
> CronJob
> Pod
> Service
Unused: 
> HorizontalPodAutoScaler
> PodDisruptionBudget
> NetworkPolicy
(matthisholleville) ➜  k8sgpt git:(fix/integration-and-filters) go run main.go integration activate trivy
...
Activated integration trivy
(matthisholleville) ➜  k8sgpt git:(fix/integration-and-filters) go run main.go filters list              
Active: 
> Deployment
> Ingress
> Node
> Service
> CronJob
> ReplicaSet
> PersistentVolumeClaim
> VulnerabilityReport (integration)
> Pod
> StatefulSet
Unused: 
> HorizontalPodAutoScaler
> PodDisruptionBudget
> NetworkPolicy

… added

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville requested review from a team as code owners May 18, 2023 21:00
@panpan0000
Copy link
Contributor

πŸ‘

@matthisholleville matthisholleville merged commit b7dc384 into k8sgpt-ai:main May 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] After integration activate, k8sgpt analyze will never run the Core Analyzers.
3 participants