Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure ingress HTTP rule exists to prevent analyze panic #726

Merged
merged 2 commits into from Nov 3, 2023
Merged

fix: ensure ingress HTTP rule exists to prevent analyze panic #726

merged 2 commits into from Nov 3, 2023

Conversation

testA113
Copy link
Contributor

@testA113 testA113 commented Nov 1, 2023 •
edited

Closes #653

📑 Description

The issue described gives a panic since the rule.HTTP field may not exist in an ingress object. My fix checks if the HTTP field rule.HTTP exists before looping though the rule.HTTP.Paths

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@testA113 testA113 requested review from a team as code owners November 1, 2023 17:56
@testA113
fix: ensure ingress HTTP rule exists to prevent panic
a9e3fbe 
Signed-off-by: Ali Harris <aliharriss1995@gmail.com>
@testA113 testA113 force-pushed the fix/no-ingress-paths-analyze-panic2 branch from ee80c91 to a9e3fbe Compare November 1, 2023 18:06
arbreezy
arbreezy approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arbreezy arbreezy merged commit 37721b5 into k8sgpt-ai:main Nov 3, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Nov 3, 2023
Merged
@testA113 testA113 deleted the fix/no-ingress-paths-analyze-panic2 branch November 19, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbreezy arbreezy arbreezy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Panic when analyzing ingress that has no paths (w suggested fix)
2 participants
@testA113 @arbreezy