Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MedusaTask deletes medusaBackups of another clusters in the same namespace #1017

Closed
18ab21 opened this issue Jul 10, 2023 · 0 comments · Fixed by #1025
Closed

MedusaTask deletes medusaBackups of another clusters in the same namespace #1017

18ab21 opened this issue Jul 10, 2023 · 0 comments · Fixed by #1025
Assignees
Labels
bug Something isn't working done Issues in the state 'done'

Comments

@18ab21
Copy link

18ab21 commented Jul 10, 2023

What happened?
MedusaTask with operation sync deletes medusabackups of another cassandradatacenters in namespace.

Did you expect to see something different?
I expect, that MedusaTask deletes only medusabackups of its own cassandraDatacenter

How to reproduce it (as minimally and precisely as possible):

  1. Create two k8ssandraclusters in one namespace
  2. Create N (N > maxBackupCount ) medusabackupjobs for each cassandradatecenter
  3. See kubectl -n yournamespace get medusabackups
  4. Create medusapurgetask for one datacenter
  5. See kubectl -n yournamespace get medusabackups
  6. See logs of k8ssandra-operator

Environment

  • K8ssandra Operator version:

k8ssandra-operator:v1.6.0

  • Kubernetes version information:

GitVersion:"v1.23.14"

  • Kubernetes cluster kind:

  • K8ssandra Operator Logs:

2023-07-10T12:39:59.942Z        INFO    Syncing Backup  {"controller": "medusatask", "controllerGroup": "medusa.k8ssandra.io", "controllerKind": "MedusaTask", "MedusaTask": {"name":"purge-backyo-agtest3-dca-sync","namespace":"cassandra-as
-service"}, "namespace": "cassandra-as-service", "name": "purge-backyo-agtest3-dca-sync", "reconcileID": "bafdc80b-c472-4161-9411-53bb7f186b0c", "MedusaTask": "cassandra-as-service/purge-backyo-agtest3-dca-sync", "cassdc": "agtest3-dca", "Backup": "backup-agtest3-dcb-1688992535"}
2023-07-10T12:39:59.942Z        INFO    Syncing Backup  {"controller": "medusatask", "controllerGroup": "medusa.k8ssandra.io", "controllerKind": "MedusaTask", "MedusaTask": {"name":"purge-backyo-agtest3-dca-sync","namespace":"cassandra-as-service"}, "namespace": "cassandra-as-service", "name": "purge-backyo-agtest3-dca-sync", "reconcileID": "bafdc80b-c472-4161-9411-53bb7f186b0c", "MedusaTask": "cassandra-as-service/purge-backyo-agtest3-dca-sync", "cassdc": "agtest3-dca", "Backup": "backup-agtest3-dca-1688992692"}
2023-07-10T12:39:59.942Z        INFO    Syncing Backup  {"controller": "medusatask", "controllerGroup": "medusa.k8ssandra.io", "controllerKind": "MedusaTask", "MedusaTask": {"name":"purge-backyo-agtest3-dca-sync","namespace":"cassandra-as-service"}, "namespace": "cassandra-as-service", "name": "purge-backyo-agtest3-dca-sync", "reconcileID": "bafdc80b-c472-4161-9411-53bb7f186b0c", "MedusaTask": "cassandra-as-service/purge-backyo-agtest3-dca-sync", "cassdc": "agtest3-dca", "Backup": "backup-agtest3-dcb-1688992692"}
2023-07-10T12:39:59.942Z        INFO    Deleting Cassandra Backup       {"controller": "medusatask", "controllerGroup": "medusa.k8ssandra.io", "controllerKind": "MedusaTask", "MedusaTask": {"name":"purge-backyo-agtest3-dca-sync","namespace":"cassandra-as-service"}, "namespace": "cassandra-as-service", "name": "purge-backyo-agtest3-dca-sync", "reconcileID": "bafdc80b-c472-4161-9411-53bb7f186b0c", "MedusaTask": "cassandra-as-service/purge-backyo-agtest3-dca-sync", "cassdc": "agtest3-dca", "Backup": "backup-agtest2-d-dcb"}
2023-07-10T12:39:59.970Z        INFO    Deleted Cassandra Backup        {"controller": "medusatask", "controllerGroup": "medusa.k8ssandra.io", "controllerKind": "MedusaTask", "MedusaTask": {"name":"purge-backyo-agtest3-dca-sync","namespace":"cassandra-as-service"}, "namespace": "cassandra-as-service", "name": "purge-backyo-agtest3-dca-sync", "reconcileID": "bafdc80b-c472-4161-9411-53bb7f186b0c", "MedusaTask": "cassandra-as-service/purge-backyo-agtest3-dca-sync", "cassdc": "agtest3-dca", "Backup": "backup-agtest2-d-dcb"}
2023-07-10T12:39:59.970Z        INFO    Deleting Cassandra Backup       {"controller": "medusatask", "controllerGroup": "medusa.k8ssandra.io", "controllerKind": "MedusaTask", "MedusaTask": {"name":"purge-backyo-agtest3-dca-sync","namespace":"cassandra-as-service"}, "namespace": "cassandra-as-service", "name": "purge-backyo-agtest3-dca-sync", "reconcileID": "bafdc80b-c472-4161-9411-53bb7f186b0c", "MedusaTask": "cassandra-as-service/purge-backyo-agtest3-dca-sync", "cassdc": "agtest3-dca", "Backup": "backup-agtest2-dca-1688992534"}
2023-07-10T12:39:59.998Z        INFO    Deleted Cassandra Backup        {"controller": "medusatask", "controllerGroup": "medusa.k8ssandra.io", "controllerKind": "MedusaTask", "MedusaTask": {"name":"purge-backyo-agtest3-dca-sync","namespace":"cassandra-as-service"}, "namespace": "cassandra-as-service", "name": "purge-backyo-agtest3-dca-sync", "reconcileID": "bafdc80b-c472-4161-9411-53bb7f186b0c", "MedusaTask": "cassandra-as-service/purge-backyo-agtest3-dca-sync", "cassdc": "agtest3-dca", "Backup": "backup-agtest2-dca-1688992534"}
2023-07-10T12:39:59.998Z        INFO    Deleting Cassandra Backup       {"controller": "medusatask", "controllerGroup": "medusa.k8ssandra.io", "controllerKind": "MedusaTask", "MedusaTask": {"name":"purge-backyo-agtest3-dca-sync","namespace":"cassandra-as-service"}, "namespace": "cassandra-as-service", "name": "purge-backyo-agtest3-dca-sync", "reconcileID": "bafdc80b-c472-4161-9411-53bb7f186b0c", "MedusaTask": "cassandra-as-service/purge-backyo-agtest3-dca-sync", "cassdc": "agtest3-dca", "Backup": "backup-agtest2-dcb-1688992691"}
2023-07-10T12:40:00.163Z        INFO    Deleted Cassandra Backup        {"controller": "medusatask", "controllerGroup": "medusa.k8ssandra.io", "controllerKind": "MedusaTask", "MedusaTask": {"name":"purge-backyo-agtest3-dca-sync","namespace":"cassandra-as-service"}, "namespace": "cassandra-as-service", "name": "purge-backyo-agtest3-dca-sync", "reconcileID": "bafdc80b-c472-4161-9411-53bb7f186b0c", "MedusaTask": "cassandra-as-service/purge-backyo-agtest3-dca-sync", "cassdc": "agtest3-dca", "Backup": "backup-agtest2-dcb-1688992691"}

Anything else we need to know?:

I think in this https://github.com/k8ssandra/k8ssandra-operator/blob/main/controllers/medusa/medusatask_controller.go#L297 place we should to add condition "&& backup.Spec.CassandraDatacenter == task.Spec.CassandraDatacenter"

@18ab21 18ab21 added the bug Something isn't working label Jul 10, 2023
@adejanovski adejanovski added the ready-for-review Issues in the state 'ready-for-review' label Jul 24, 2023
@burmanm burmanm self-assigned this Jul 27, 2023
@adejanovski adejanovski added review Issues in the state 'review' and removed ready-for-review Issues in the state 'ready-for-review' labels Aug 5, 2023
@adejanovski adejanovski added done Issues in the state 'done' and removed review Issues in the state 'review' labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Issues in the state 'done'
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants