Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore mapping seems to shuffle the pods during in place restores #1060

Closed
2 tasks
adejanovski opened this issue Sep 21, 2023 · 0 comments · Fixed by #1076
Closed
2 tasks

Restore mapping seems to shuffle the pods during in place restores #1060

adejanovski opened this issue Sep 21, 2023 · 0 comments · Fixed by #1076
Labels
bug Something isn't working done Issues in the state 'done'

Comments

@adejanovski
Copy link
Contributor

When creating a MedusaRestoreJob, the restore mapping is computed by the operator and stored in the object status. It is then use by each node to figure out which backup node it should restore from.

In case of an in place restore (we're restoring a backup that was taken on the same cluster), each node should map to itself.
It doesn't seem to be the case and I can see nodes being shuffled in the restore mapping:

  restoreMapping:
    host_map:
      dogfood-mc-dc1-r1-sts-0:
        seed: false
        source:
          - dogfood-mc-dc1-r1-sts-1
      dogfood-mc-dc1-r1-sts-1:
        seed: false
        source:
          - dogfood-mc-dc1-r1-sts-0
      dogfood-mc-dc1-r1-sts-2:
        seed: false
        source:
          - dogfood-mc-dc1-r1-sts-2
    in_place: false

Also the in place nature of the backup isn't correctly identified.
In order to ensure restore safety, we need to make sure in place restored are correctly detected and restore mappings are consistent.

Definition of Done

@adejanovski adejanovski added the bug Something isn't working label Sep 21, 2023
@adejanovski adejanovski added the ready-for-review Issues in the state 'ready-for-review' label Oct 3, 2023
@adejanovski adejanovski added done Issues in the state 'done' and removed ready-for-review Issues in the state 'ready-for-review' labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Issues in the state 'done'
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant