Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to list Medusa backups if there are too many of them #1102

Closed
burmanm opened this issue Oct 24, 2023 · 1 comment · Fixed by #1100
Closed

Failing to list Medusa backups if there are too many of them #1102

burmanm opened this issue Oct 24, 2023 · 1 comment · Fixed by #1100
Labels
bug Something isn't working done Issues in the state 'done'

Comments

@burmanm
Copy link
Contributor

burmanm commented Oct 24, 2023

What happened?

When there are too many backups, the gRPC connection fails with the error:

│ 2023-10-23T20:41:06.011Z  ERROR  failed to list backups  {"controller": "medusatask", "controllerGroup": "medusa.k8ssandra.io", "controllerKind": "MedusaTask", "MedusaTask": {"name":"medusa-backup-sync-cluster2-main-1698093327","namespace":"k8s
│ sandra-failover"}, "namespace": "k8ssandra-failover", "name": "medusa-backup-sync-cluster2-main-1698093327", "reconcileID": "ce6efd88-b6c8-406b-bcb1-b7f7b1cd4a2e", "MedusaTask": "k8ssandra-failover/medusa-backup-sync-cluster2-main-1698093327", "cassd
│ c": "main", "CassandraPod": "cluster2-main-az-1c-sts-1", "error": "failed to get backups: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (10903823 vs. 4194304)"}

This is because our gRPC setting allows the reply to be a maximum of 4MB, which isn't enough.

Did you expect to see something different?

We should probably split the request to multiple parts, or something else. Otherwise we'll be chasing some arbitary number and keep increasing the size forever (and it will start causing network transfer errors). We might also consider compression on this connection.

How to reproduce it (as minimally and precisely as possible):

Environment

  • K8ssandra Operator version:

    Insert image tag or Git SHA here

  • Kubernetes version information:

    kubectl version

  • Kubernetes cluster kind:

    insert how you created your cluster: kops, bootkube, etc.

  • Manifests:

insert manifests relevant to the issue
  • K8ssandra Operator Logs:
insert K8ssandra Operator logs relevant to the issue here

Anything else we need to know?:

@KEDLogic
Copy link

This issue is actually for our cluster. I had mistakenly created a ticket on medusa-operator. It has some additional info that may be relevent: k8ssandra/medusa-operator#71

Thank you burmanm for posting this :)

@adejanovski adejanovski added the done Issues in the state 'done' label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Issues in the state 'done'
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants