Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup sync operator should cleanup MedusaBackupJob objects #1196

Closed
1 task
adejanovski opened this issue Jan 31, 2024 · 1 comment
Closed
1 task

Backup sync operator should cleanup MedusaBackupJob objects #1196

adejanovski opened this issue Jan 31, 2024 · 1 comment
Labels
done Issues in the state 'done'

Comments

@adejanovski
Copy link
Contributor

The sync MedusaTask deletes MedusaBackup objects that don't have an actual backup in the storage bucket.
But it leaves the MedusaBackupJob objects, which can pile up a lot over time.
We'd need to make them part of the cleanup, deleting the MedusaBackupJobs for backups that have been purged from the storage bucket. This should only happen if the MedusaBackupJob is finished already (may it be successful or not). Pending/Running jobs should be left untouched.

Definition of Done

@adejanovski adejanovski added the ready Issues in the state 'ready' label Jan 31, 2024
@adejanovski
Copy link
Contributor Author

This was done in #1347

@adejanovski adejanovski added done Issues in the state 'done' and removed ready Issues in the state 'ready' labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Issues in the state 'done'
Projects
Status: Done
Development

No branches or pull requests

1 participant