Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent transfers from a MedusaConfiguration is always overridden by 1 #1239

Closed
2 tasks
adejanovski opened this issue Mar 12, 2024 · 0 comments · Fixed by #1244
Closed
2 tasks

Concurrent transfers from a MedusaConfiguration is always overridden by 1 #1239

adejanovski opened this issue Mar 12, 2024 · 0 comments · Fixed by #1244
Assignees
Labels
bug Something isn't working done Issues in the state 'done'

Comments

@adejanovski
Copy link
Contributor

adejanovski commented Mar 12, 2024

The Medusa storage properties defined in a K8ssandraCluster spec use 1 as kubebuilder default for concurrent_transfers. As this is not the "zero value" for integers, it always wins against the value defined in a MedusaConfiguration.

In order to fix this, while retaining the priority of the storage properties over the MedusaConfiguration, we need to modify the default and set it to 0, and modify the code that generates the medusa.ini configmap entry to swap 0 for 1 in case it wasn't defined in either the MedusaConfiguration nor the storage properties.

Definition of Done

@adejanovski adejanovski added bug Something isn't working ready Issues in the state 'ready' labels Mar 12, 2024
@rzvoncek rzvoncek self-assigned this Mar 13, 2024
@adejanovski adejanovski added in-progress Issues in the state 'in-progress' and removed ready Issues in the state 'ready' labels Mar 13, 2024
@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' review Issues in the state 'review' and removed in-progress Issues in the state 'in-progress' ready-for-review Issues in the state 'ready-for-review' labels Mar 13, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed review Issues in the state 'review' labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Issues in the state 'done'
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants