Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector container is not correctly created in cassDC #1323

Closed
Miles-Garnsey opened this issue May 23, 2024 · 2 comments · Fixed by #1322
Closed

Vector container is not correctly created in cassDC #1323

Miles-Garnsey opened this issue May 23, 2024 · 2 comments · Fixed by #1322
Labels
bug Something isn't working done Issues in the state 'done'

Comments

@Miles-Garnsey
Copy link
Member

Miles-Garnsey commented May 23, 2024

What happened?

  • The podSecurityContext isn't being validated properly, I can include stuff like capabilities in this field, even though that doesn't exist on the PodSecurityContext type.
  • When adding configurations to the Container field for the server-system-logger container, it appears that these do not propagate into the CassDC as expected.

A test demonstrating these problems can be found here.

@burmanm
Copy link
Contributor

burmanm commented May 23, 2024

The image that is ending up in the sts is actually system logger instead of the vector container that should appear. This is despite vector being enabled. I'm pretty sure that means it should be a vector image instead of the system-logger image since this is the default from the struct tags if the vector struct is non-nil.

In case this ticket gets mentioned in the release notes: This isn't correct, the server-system-logger is a docker image that bundles Vector, since cass-operator uses Vector to do the tailing (and provides the capabilities to modify how Vector is used).

One should not replace the server-system-logger image with the vector.io ones.

@Miles-Garnsey
Copy link
Member Author

In case this ticket gets mentioned in the release notes: This isn't correct, the server-system-logger is a docker image that bundles Vector, since cass-operator uses Vector to do the tailing (and provides the capabilities to modify how Vector is used).

Alex explained to me that this had been changed a while back. I didn't realised we'd started doing it this way - makes sense now he's explained it.

@adejanovski adejanovski added the ready-for-review Issues in the state 'ready-for-review' label May 23, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed ready-for-review Issues in the state 'ready-for-review' labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Issues in the state 'done'
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants