Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SSAND-1821 ⁃ Ability to merge cluster- and dc- level configs #715

Closed
adutra opened this issue Oct 11, 2022 · 1 comment · Fixed by #780
Closed

K8SSAND-1821 ⁃ Ability to merge cluster- and dc- level configs #715

adutra opened this issue Oct 11, 2022 · 1 comment · Fixed by #780
Labels
done Issues in the state 'done' enhancement New feature or request

Comments

@adutra
Copy link
Contributor

adutra commented Oct 11, 2022

What is missing?

Currently cluster-level configs are coalesced with dc-level ones in an all-or-nothing fashion: if the dc-level config is present, then the cluster-level one is ignored.

Why do we need it?

With #710, YAML config files are now schemaless in the CRD and represented internally as map[string]interface{}. It should be fairly simple to use utils.MergeMapNested to merge cluster-level and dc-level configs.

Note: JVM options are still schemaful so we can't apply this fix to the JvmOptions struct. We might be able to write custom code to handle it, or resort to merging libraries as suggested in #526.

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1821
┆priority: Medium

@adutra adutra added the enhancement New feature or request label Oct 11, 2022
@sync-by-unito sync-by-unito bot changed the title Ability to merge cluster- and dc- level configs K8SSAND-1821 ⁃ Ability to merge cluster- and dc- level configs Oct 11, 2022
@adutra
Copy link
Contributor Author

adutra commented Nov 25, 2022

This is going to be superseded by #525, I have a PR up for that: #780.

@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' review Issues in the state 'review' and removed ready-for-review Issues in the state 'ready-for-review' labels Nov 30, 2022
@adejanovski adejanovski added done Issues in the state 'done' and removed review Issues in the state 'review' labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Issues in the state 'done' enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants